Bug 348674

Summary:	Crash Recovery only works properly for unsaved projects
Product:	[Applications] kdenlive	Reporter:	walmartshopper
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	major	CC:	ttguy1, wegwerf-1-2-3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description walmartshopper 2015-06-03 22:27:13 UTC

If I'm working on a project that has not yet been saved and kdenlive crashes (which it does frequently for me), kdenlive asks me if I want to recover the project next time it starts.  And it recovers correctly, restoring everything to right before the crash.

However, if I'm working on a saved project and kdenlive crashes, I do not get the recovery prompt.  It simply opens a blank unsaved project.  If I re-open the project I was working on, it opens up in the state where I last saved it manually.  So if I haven't saved recently, I lose some of my work.

Reproducible: Always

Steps to Reproduce:
1. Make sure crash recovery is turned on and open a saved project
2. Move some things around in the timeline
3. Do something that makes kdenlive crash, like playing an animated title clip in the clip monitor
4. Open kdenlive

Actual Results:  
There is no prompt to recover the project.  Re-opening the project opens the last manually-saved state.  There is nothing under "Open Backup File" that would restore it to the state right before the crash.  I do get the recovery prompt if the project was never saved.

Expected Results:  
I should be prompted to recover the saved project, not just unsaved/untitled projects.

Version 15.04.2

Kdenlive crashes on me roughly every 15 minutes, so crash recovery is an important feature to me.  The only way I can work on a saved project without losing my work is to press Ctrl+s after everything I do.

Comment 1 Jean-Baptiste Mardelle 2015-06-03 23:27:01 UTC

The autosave feature was done in such a way that it only saves after 3 seconds of inactivity if you have made a change. That might be a problem if you work fast and make no pause, then crashing Kdenlive can make you lose your work.

Can you check that:

1. Open your saved project
2. Make some changes
3. wait for 4-5 seconds
4. Crash Kdenlive (you can simply kill it from the task manager or Ctrl+Alt+Esc)
5. Try re-opening your project, you will be prompted for recovery and it should recover the unsaved project

Please let me know if it works this way. I could change the autosave to force saving after 1 minute of work, even if there is no pause in the workflow...

Comment 2 walmartshopper 2015-06-05 22:02:05 UTC

Still happens.  I opened a project, moved some stuff around the timeline, waited about a minute, killed with ctrl+alt+esc.  When I re-opened, no recovery prompt and nothing in the restore backup window.

Comment 3 Jean-Baptiste Mardelle 2015-06-06 19:43:16 UTC

Git commit 28b3cc7b5141fcc2fed84433b9fe9851c35b7e08 by Jean-Baptiste Mardelle.
Committed on 06/06/2015 at 19:42.
Pushed by mardelle into branch 'Applications/15.04'.

Fix autosave not working when opening project file from command line or click in file browser

M  +4    -0    src/main.cpp

http://commits.kde.org/kdenlive/28b3cc7b5141fcc2fed84433b9fe9851c35b7e08

Comment 4 Jean-Baptiste Mardelle 2015-06-06 19:45:12 UTC

Ok, I think I found the problem. It was only happening when opening the project file from command line or when clicking on a project file in a file browser, but not when opening the project file from inside Kdenlive.

Can you confirm how you open your project files when the bug happens ?

Comment 5 Jean-Baptiste Mardelle 2015-06-07 19:39:40 UTC

Git commit cc55a9cea5c2f029744f8aba79a362fd302ec0bb by Jean-Baptiste Mardelle.
Committed on 06/06/2015 at 19:41.
Pushed by mardelle into branch 'master'.

Fix autosave not working when opening project file from command line or click in file browser

M  +4    -0    src/main.cpp

http://commits.kde.org/kdenlive/cc55a9cea5c2f029744f8aba79a362fd302ec0bb

Comment 6 walmartshopper 2015-06-08 05:21:32 UTC

I usually open by clicking in dolphin, but I just tried File > Open and File > Open Recent inside kdenlive and didn't get any autosave with those methods either.

Comment 7 Roger Morton 2015-09-22 14:16:10 UTC

This is working OK for me in ver 15.09