Bug 348594

Summary:	Qt5/KF5 build can't detect phonon and QtExtSerialPort builded with Qt5
Product:	[Applications] marble	Reporter:	Gustavo Alvarez <sl1pkn07>
Component:	general	Assignee:	Dennis Nienhüser <nienhueser>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nienhueser
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/marble/d010369c659729b1c635da853bf03e9b58811190	Version Fixed In:
Sentry Crash Report:

Description Gustavo Alvarez 2015-06-02 13:51:08 UTC

When build marble with Qt5/KF5, the cmake can't detect the Qt5 builds of  phonon and QtExtSerialPort

the files installed of the phonon and QtExtSerialPort buided with Qt5 are:

phonon: http://sl1pkn07.wtf/paste/view/0805858c
QtExtSerialPort: http://sl1pkn07.wtf/paste/view/e98eb765

in marble/cmake/modules/{FindQtExtSerialPort,FindPhonon}.cmake only search the Qt4 build

need selectors and fix the paths like a Findquazip.cmake 

Reproducible: Always

Steps to Reproduce:
1.build Phonon and QtExtSerialPort with Qt5 support
2.download marble from git
3. see the cmake symmary output

Actual Results:  
cmake detect phonon and QtExtSerialPort builded with Qt4 (detected only the library, the header are missing)

Expected Results:  
detect Qt5 build phonon and QtExtSerialPort

if pass to cmake

-DPHONON_INCLUDE_DIR=/usr/include/phonon4qt5
-DPHONON_LIBRARY=/usr/lib/phonon4qt5.so
-DQEXTSERIALPORT_INCLUDE_DIR=/usr/include/qt/QtExtSerialPort
-DQEXTSERIALPORT_LIBRARIES=/usr/lib/libQt5ExtSerialPort.so

the build and detect are ok

Comment 1 Dennis Nienhüser 2015-06-04 08:23:05 UTC

Thanks, looks reasonable. I'll fix it like that once I have a test system around (early next week) unless someone beats me to it.

Comment 2 Dennis Nienhüser 2015-06-08 19:00:18 UTC

Git commit d33b43fd35836cdb578abdbeda153c0907a67400 by Dennis Nienhüser.
Committed on 08/06/2015 at 18:59.
Pushed by nienhueser into branch 'master'.

Search for phonon4qt5 in Qt5 builds

M  +7    -2    cmake/modules/FindPhonon.cmake

http://commits.kde.org/marble/d33b43fd35836cdb578abdbeda153c0907a67400

Comment 3 Dennis Nienhüser 2015-06-08 19:57:40 UTC

Git commit d010369c659729b1c635da853bf03e9b58811190 by Dennis Nienhüser.
Committed on 08/06/2015 at 19:56.
Pushed by nienhueser into branch 'master'.

Search for Qt5 version of QExtSerialPort in Qt5 builds

M  +7    -2    cmake/modules/FindQextSerialPort.cmake

http://commits.kde.org/marble/d010369c659729b1c635da853bf03e9b58811190

Comment 4 Gustavo Alvarez 2015-06-08 21:42:47 UTC

yep, now detect ok phonon/QextSerialPort Qt5 witout adjust cmake options

test with Qt4 and Qt5 build

fixed

thanks