Bug 348556

Summary: ac91cf9f27 commit not finnished. fail build if enable build examples
Product: [Applications] marble Reporter: Gustavo Alvarez <sl1pkn07>
Component: generalAssignee: marble-bugs
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/marble/bca1f72373330f18cba697d4f5b5f33dad6fcb28 Version Fixed/Implemented In:
Sentry Crash Report:

Description Gustavo Alvarez 2015-06-01 19:06:20 UTC 
http://quickgit.kde.org/?p=marble.git&a=commit&h=ac91cf9f27c355754fd7e8c6df9256a753cb8545 commit not finished

when build fail because need make a changes in other files. if not fail build by libraryes not found

Generating MarblePhysics.moc
/usr/bin/ld: cannot find -lmarblewidget
collect2: error: ld returned 1 exit status
examples/cpp/animation-video/CMakeFiles/animation-video.dir/build.make:114: recipe for target 'examples/cpp/animation-video/animation-video' failed
make[2]: *** [examples/cpp/animation-video/animation-video] Error 1
CMakeFiles/Makefile2:9457: recipe for target 'examples/cpp/animation-video/CMakeFiles/animation-video.dir/all' failed
make[1]: *** [examples/cpp/animation-video/CMakeFiles/animation-video.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lmarblewidget
collect2: error: ld returned 1 exit status
[ 14%] examples/cpp/tour-preview/CMakeFiles/tour-preview.dir/build.make:114: recipe for target 'examples/cpp/tour-preview/tour-preview' failed
make[2]: *** [examples/cpp/tour-preview/tour-preview] Error 1
CMakeFiles/Makefile2:9539: recipe for target 'examples/cpp/tour-preview/CMakeFiles/tour-preview.dir/all' failed
make[1]: *** [examples/cpp/tour-preview/CMakeFiles/tour-preview.dir/all] Error 2
Built target stars

the files need fixed :

marble/examples/cpp/marble-game/CMakeLists.txt
marble/examples/cpp/tour-preview/CMakeLists.txt
marble/examples/cpp/animation-video/CMakeLists.txt
marble/examples/cpp/pie-charts/CMakeLists.txt
marble/examples/cpp/kml-screenshot/CMakeLists.txt
marble/examples/cpp/route-image/CMakeLists.txt


Reproducible: Always

Steps to Reproduce:
1.download marble sources and set up for qt5/kf5 and enable the examples
2.start build


Actual Results:  
build all ok

Expected Results:  
fail build

need change the target_link_libraries() from 'marblewidget' to '${MARBLEWIDGET}'
Comment 1 Dennis Nienhüser 2015-06-01 19:15:56 UTC 
Git commit bca1f72373330f18cba697d4f5b5f33dad6fcb28 by Dennis Nienhüser.
Committed on 01/06/2015 at 19:14.
Pushed by nienhueser into branch 'master'.

marblewidget library name now depends on Qt version

M  +1    -1    examples/cpp/animation-video/CMakeLists.txt
M  +1    -1    examples/cpp/kml-screenshot/CMakeLists.txt
M  +1    -1    examples/cpp/pie-charts/CMakeLists.txt
M  +1    -1    examples/cpp/route-image/CMakeLists.txt
M  +1    -1    examples/cpp/tour-preview/CMakeLists.txt

http://commits.kde.org/marble/bca1f72373330f18cba697d4f5b5f33dad6fcb28