| Summary: | Fail build. quazip(qt4) header path hardcoded in marble/src/plugins/runner/kml/KmzHandler.cpp when try build with Qt5/KF5 | ||
|---|---|---|---|
| Product: | [Applications] marble | Reporter: | Gustavo Alvarez <sl1pkn07> |
| Component: | general | Assignee: | marble-bugs |
| Status: | RESOLVED FIXED | ||
| Severity: | grave | CC: | nienhueser, rdieter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/marble/e640a4bf12fdbd33ccb9c5b7820effe341898535 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Gustavo Alvarez
2015-06-01 18:23:18 UTC
We need some way to determine whether quazip was built against Qt4 or Qt5. When using quazip/Qt4 with Marble/Qt5, you'll get a crash at runtime. @Rex: How does Fedora package quazip? From a quick look at the sources it seems quazip itself does not use any Qt 5 special postfixes in its installation. Is that changed in Fedora? I'm wondering because of http://quickgit.kde.org/?p=marble.git&a=commit&h=030b7de Quazip upstream uses a "5" postfix, starting from: https://sourceforge.net/p/quazip/code/254/ which is why I made the aforementioned commit to marble to follow suit. (I guess I should have referenced that in the marble commit to make that clear, my apologies) quazip, qhen build with Qt5 install:
/usr/
/usr/include/
/usr/include/quazip5/
/usr/include/quazip5/JlCompress.h
/usr/include/quazip5/crypt.h
/usr/include/quazip5/ioapi.h
/usr/include/quazip5/quaadler32.h
/usr/include/quazip5/quachecksum32.h
/usr/include/quazip5/quacrc32.h
/usr/include/quazip5/quagzipfile.h
/usr/include/quazip5/quaziodevice.h
/usr/include/quazip5/quazip.h
/usr/include/quazip5/quazip_global.h
/usr/include/quazip5/quazipdir.h
/usr/include/quazip5/quazipfile.h
/usr/include/quazip5/quazipfileinfo.h
/usr/include/quazip5/quazipnewinfo.h
/usr/include/quazip5/unzip.h
/usr/include/quazip5/zip.h
/usr/lib/
/usr/lib/libquazip.a
/usr/lib/libquazip5.so
/usr/lib/libquazip5.so.1
/usr/lib/libquazip5.so.1.0.0
/usr/share/
/usr/share/cmake-3.2/
/usr/share/cmake-3.2/Modules/
/usr/share/cmake-3.2/Modules/FindQuaZip5.cmake
and when build with qt4:
/usr/
/usr/include/
/usr/include/quazip/
/usr/include/quazip/JlCompress.h
/usr/include/quazip/crypt.h
/usr/include/quazip/ioapi.h
/usr/include/quazip/quaadler32.h
/usr/include/quazip/quachecksum32.h
/usr/include/quazip/quacrc32.h
/usr/include/quazip/quagzipfile.h
/usr/include/quazip/quaziodevice.h
/usr/include/quazip/quazip.h
/usr/include/quazip/quazip_global.h
/usr/include/quazip/quazipdir.h
/usr/include/quazip/quazipfile.h
/usr/include/quazip/quazipfileinfo.h
/usr/include/quazip/quazipnewinfo.h
/usr/include/quazip/unzip.h
/usr/include/quazip/zip.h
/usr/lib/
/usr/lib/libquazip.so
/usr/lib/libquazip.so.1
/usr/lib/libquazip.so.1.0
/usr/lib/libquazip.so.1.0.0
/usr/share/
/usr/share/cmake-3.2/
/usr/share/cmake-3.2/Modules/
/usr/share/cmake-3.2/Modules/FindQuaZip.cmake
both buid with: qmake-qt{4,5} PREFIX=/usr (both from SVN) (waiting to release for use a cmake build system)
Thanks for the fast replies. I was looking at quazip-0.7.1, which is the latest release but still before the introduction of the 5 postfix. I can reproduce the problem now, working on a fix. Git commit e640a4bf12fdbd33ccb9c5b7820effe341898535 by Dennis Nienhüser. Committed on 01/06/2015 at 20:02. Pushed by nienhueser into branch 'master'. quazip for Qt5 is installed to quazip5/ since rev 254 See http://sourceforge.net/p/quazip/code/254/ M +2 -2 cmake/modules/Findquazip.cmake M +2 -2 src/plugins/runner/kml/KmzHandler.cpp http://commits.kde.org/marble/e640a4bf12fdbd33ccb9c5b7820effe341898535 |