Bug 348380

Summary:	When no documents are open, If you add "Clear" to "Brushes and Stuff" and you click on it, you get a crash
Product:	[Applications] krita	Reporter:	mvowada <freebox64>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	halla, reinfaria
Priority:	NOR
Version First Reported In:	2.9.4
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/a2125776131828c2f14ec41c6c1eb4dd874eb6cb	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	GDB report.

Description mvowada 2015-05-29 01:58:51 UTC

It seems it is possible to configure the toolbars when no documents are open, but there are inconsistencies with the list items proposed and their activation.

If you add "Clear" to "Brushes and Stuff" and you click on it, you get a crash (see the GDB report below).

Reproducible: Always

Steps to Reproduce:
1. Start Krita
2. Configure the toolbars by going in: (main menu) > Settings > Configure Toolbars...
3. add the "Clear" button to the "Brushes and Stuff" toolbar and Save
4. click the "Clear" button in the toolbar

Actual Results:  
Krita crash.

Expected Results:  
Is it expected being able to configure the toolbars, when no document are open?
But there are inconsistencies with the list items proposed and their activation.

Comment 1 mvowada 2015-05-29 01:59:37 UTC

Created attachment 92898 [details]
GDB report.

Comment 2 Halla Rempt 2015-05-29 07:37:51 UTC

Thread 1 (Thread 0x7fe13cf9c7c0 (LWP 2595)):
[KCrash Handler]
#5  0x00007fe13c7e730c in KisClearActionFactory::run(KisViewManager*) (this=this@entry=0x7fff046b70c0, view=<optimized out>) at /home/boud/kde/src/2.9/krita/ui/actions/kis_selection_action_factories.cpp:236
#6  0x00007fe13c679bc7 in KisSelectionManager::clear() (this=0x410a7d0) at /home/boud/kde/src/2.9/krita/ui/kis_selection_manager.cc:481
#7  0x00007fe13c680345 in KisSelectionManager::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=0x410a7d0, _c=<optimized out>, _id=18, _a=<optimized out>) at /home/boud/kde/build/2.9/krita/ui/kis_selection_manager.moc:122
#8  0x00007fe134f971fa in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () at /usr/lib64/libQtCore.so.4
#9  0x00007fe13598b622 in QAction::triggered(bool) () at /usr/lib64/libQtGui.so.4
#10 0x00007fe13598cfd3 in QAction::activate(QAction::ActionEvent) () at /usr/lib64/libQtGui.so.4
#11 0x00007fe135d3f112 in  () at /usr/lib64/libQtGui.so.4
#12 0x00007fe135d3f23c in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () at /usr/lib64/libQtGui.so.4
#13 0x00007fe135df616a in QToolButton::mouseReleaseEvent(QMouseEvent*) () at /usr/lib64/libQtGui.so.4
#14 0x00007fe1359e0c0a in QWidget::event(QEvent*) () at /usr/lib64/libQtGui.so.4
#15 0x00007fe13599176c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib64/libQtGui.so.4
#16 0x00007fe135997dea in QApplication::notify(QObject*, QEvent*) () at /usr/lib64/libQtGui.so.4
#17 0x00007fe13c836fa7 in KisApplication::notify(QObject*, QEvent*) (this=<optimized out>, receiver=0x4961e90, event=0x7fff046b7760) at /home/boud/kde/src/2.9/krita/ui/KisApplication.cpp:493
#18 0x00007fe134f832ad in QCoreApplication::notifyInternal(QObject*, QEvent*) () at /usr/lib64/libQtCore.so.4
#19 0x00007fe1359975e3 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) () at /usr/lib64/libQtGui.so.4
#20 0x00007fe135a08c9b in  () at /usr/lib64/libQtGui.so.4
#21 0x00007fe135a0770c in QApplication::x11ProcessEvent(_XEvent*) () at /usr/lib64/libQtGui.so.4
#22 0x00007fe135a2ef30 in  () at /usr/lib64/libQtGui.so.4
#23 0x00007fe134f81e6f in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQtCore.so.4
#24 0x00007fe134f82165 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib64/libQtCore.so.4
#25 0x00007fe134f875b9 in QCoreApplication::exec() () at /usr/lib64/libQtCore.so.4
#26 0x0000000000402af9 in main(int, char**) (argc=<optimized out>, argv=<optimized out>) at /home/boud/kde/src/2.9/krita/main.cc:188

Comment 3 Halla Rempt 2015-05-29 07:44:04 UTC

Git commit a2125776131828c2f14ec41c6c1eb4dd874eb6cb by Boudewijn Rempt.
Committed on 29/05/2015 at 07:43.
Pushed by rempt into branch 'calligra/2.9'.

M  +2    -0    krita/ui/kis_selection_manager.cc

http://commits.kde.org/calligra/a2125776131828c2f14ec41c6c1eb4dd874eb6cb