Summary: | Export to GDrive fails when photo description contains double quotes | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Alexander Potashev <aspotashev> |
Component: | Plugin-WebService-Google | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kipi-plugins/e02a738c15e1f46a6c1d3a4c569ff339df212401 | Version Fixed In: | 4.11.0 |
Sentry Crash Report: |
Description
Alexander Potashev
2015-05-26 22:40:27 UTC
Alexander, Not reproducible here. Did you have a problem with you Gdrive account ? Gilles Caulier It probably does not work with tests/kipicmd. Now I tried the same with KPhotoAlbum and it worked, except for an AVI file. And exporting to Google Photo also works when the GDrive export plugin is invoked from KPhotoAlbum. kipicmd has a very light kipi interface implemented. This can introduce side effects. To check all features of a tool, it's always better to use a kipi host. digiKam has of course the most complete kipi interface. Gilles But it should not fail with a vague error message. It should instead check for necessary host features and show a descriptive error message if the host lacks some capabilities. It's probably reported in the console when debug space are turned on. kipicmd still very simple kipi host application. Because I was tired of arguing, I tracked down the problem: the description is not escaped before inserting in the JSON sent to the server, this is how it manifests in kipicmd: {"title":"test.jpg", "description":"Image located at "file:///home/aspotashev/kde-git/digikam/tests/imgqsort/testimages/test.jpg"", "mimeType":"image/jpeg", "parents":[{"id":"0B8K7S7XmFNKpM3A1WUtqbWVNTWc"}] } Will fix it soon. Git commit e02a738c15e1f46a6c1d3a4c569ff339df212401 by Alexander Potashev. Committed on 03/06/2015 at 22:08. Pushed by aspotashev into branch 'master'. googledrive: Escape photo title and description when inserting in JSON Export to GDriver was failing when using with kipicmd because it sets the description to 'Image located at "file:///path/to/image.jpg"'. Because the double quotes were not escaped, the Google Drive server received a broken JSON and complained about it. M +34 -18 googledrive/mpform.cpp http://commits.kde.org/kipi-plugins/e02a738c15e1f46a6c1d3a4c569ff339df212401 Git commit 64d211424372890eabbe4d0c6b89a4bcdfcafc0d by Alexander Potashev. Committed on 04/06/2015 at 08:08. Pushed by aspotashev into branch 'frameworks'. Merge commit e02a738c15e1f46a6c1d3a4c569ff339df212401 from master to frameworks googledrive: Escape photo title and description when inserting in JSON Export to GDriver was failing when using with kipicmd because it sets the description to 'Image located at "file:///path/to/image.jpg"'. Because the double quotes were not escaped, the Google Drive server received a broken JSON and complained about it. M +34 -18 PORT.KF5/FACTORIZE/googledrive/mpform.cpp http://commits.kde.org/kipi-plugins/64d211424372890eabbe4d0c6b89a4bcdfcafc0d |