Bug 348157

Summary:	The symbol on the notification which pops when you could not mount a device is wrong
Product:	[Plasma] plasmashell	Reporter:	kamesh <vaddina>
Component:	Disks & Devices widget	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	codestruct, kde, kde, kdelibs-bugs-null, mklapetek, thomas.pfeiffer, valerio.passini
Priority:	NOR	Flags:	kde: VisualDesign+
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Kubuntu
OS:	Linux
URL:	http://i.imgur.com/Yym7mlH.png
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	screenshot of "could not unmount" with wrong icon

Description kamesh 2015-05-23 16:49:08 UTC

The symbol on the notification which pops when you could not mount a device is wrong. It shows green correct symbol where as it should show a red "X" (or something like that). 

I am on:

Kubuntu: 15.04
KDE Plasma Version: 5.3.0
QT version: 5.4.1
Kernel Version: 3.19.0-16-generic
OS Type: 64 bit

Reproducible: Always

Steps to Reproduce:
1. Try to mount a device which could not be mounted or do not have permissions to mount. 



Expected Results:  
Show the correct symbol

Comment 1 Kai Uwe Broulik 2015-06-04 20:32:12 UTC

The issue is that we use the "emblem-mounted" icon for the device notification which used to be a "plug" kind of icon in the Oxygen era but in Breeze those use a tick or cross. It is clearly wrong to use an action/emblem for such a notification.

Comment 2 Thomas Pfeiffer 2015-10-08 17:01:06 UTC

(In reply to Kai Uwe Broulik from comment #1)
> The issue is that we use the "emblem-mounted" icon for the device
> notification which used to be a "plug" kind of icon in the Oxygen era but in
> Breeze those use a tick or cross. It is clearly wrong to use an
> action/emblem for such a notification.

I wouldn't necessarily say it's wrong to use an emblem, but it's definitely wrong to use the emblem for "mounted" when in fact it is _not_ mounted.
But yes, the generic icon for the feedback on failed actions (don't know what filename that is) would make most sense here.

Comment 3 David Edmundson 2015-11-29 15:28:07 UTC

*** Bug 355979 has been marked as a duplicate of this bug. ***

Comment 4 Martin Klapetek 2016-03-09 18:31:44 UTC

*** Bug 360326 has been marked as a duplicate of this bug. ***

Comment 5 Gregor Mi 2016-05-16 13:35:46 UTC

Created attachment 99019 [details]
screenshot of "could not unmount" with wrong icon

Comment 6 VP 2016-07-05 13:24:25 UTC

I think that this bug can be closed since the notification system has changed its behaviour and icons and now it tells with the right icon that was possible/impossible to mount/unmount a device.

Comment 7 David Edmundson 2016-07-05 14:35:22 UTC

thanks VP