Summary: | When there is only 1 brush preset in a tag, it's not possible to pick it up. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | mvowada <freebox64> |
Component: | Usability | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla, info, jwringstad, kalia24 |
Priority: | NOR | ||
Version: | 2.9.4 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/calligra/f5df93f0f2017e12f2b5670ad3df4f53969c5f28 | Version Fixed In: | |
Attachments: | Video example. |
Description
mvowada
2015-05-22 23:55:52 UTC
Created attachment 92786 [details]
Video example.
Git commit b2cc77e89e4c246734f910db171f62afd2ad1ada by Boudewijn Rempt. Committed on 23/05/2015 at 08:55. Pushed by rempt into branch 'calligra/2.9'. This makes it possible to select a resource even if there's only one. M +1 -0 libs/widgets/KoResourceItemChooser.cpp http://commits.kde.org/calligra/b2cc77e89e4c246734f910db171f62afd2ad1ada Hello and thank you :) problem solved! (There remains still a minor discrepancy maybe, for which I will open a separate report, that is: when you switch to a new tag list, there's always the first brush preset highlighted, even though it's not the current active preset.). This patch apparently broke the / preset switch shortcut. Git commit 603562c56d1ecc21853319457cc2100b4894d862 by Dmitry Kazakov. Committed on 17/06/2015 at 13:18. Pushed by dkazakov into branch 'calligra/2.9'. Revert b2cc77e89 "This makes it possible to select a resource even if there's only one." That commit broke '/' shortcut and introduces some other bugs Related: bug 348826 M +0 -1 libs/widgets/KoResourceItemChooser.cpp http://commits.kde.org/calligra/603562c56d1ecc21853319457cc2100b4894d862 Git commit f5df93f0f2017e12f2b5670ad3df4f53969c5f28 by Stefano Bonicatti. Committed on 21/06/2015 at 21:34. Pushed by stefanobonicatti into branch 'calligra/2.9'. Fix selection bugs in the preset docker Now is possible to select again a brush that is the only one in the selected tag category. When switching tag categories if the selected preset is present in the new category, it will be selected, otherwise no preset will be, visually, selected, but the active one won't be changed, so the user can still paint. Added several checks to avoid unneeded executions and event emitting. Especially now it shouldn't be possible to break the previous preset selection/shortcut anymore. Related: bug 348444 Differential Revision: https://phabricator.kde.org/D124 M +25 -6 krita/ui/kis_paintop_box.cc M +22 -13 libs/widgets/KoResourceItemChooser.cpp M +1 -1 libs/widgets/KoResourceItemChooser.h M +5 -6 libs/widgets/KoResourceModel.cpp M +2 -2 libs/widgets/KoResourceModel.h http://commits.kde.org/calligra/f5df93f0f2017e12f2b5670ad3df4f53969c5f28 Hello and thank you once again :-) I think that this commit has been reverted by commit 411067b1de29c46b0e4db042843843937779dd9b, I will reopen this report for now. *** Bug 355886 has been marked as a duplicate of this bug. *** Closing this report as 'FIXED' since I can't reproduce this issue in Krita 3.1.1. Thanks! |