| Summary: | WISH: Plasmashell digital clock font should be configurable | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | sombragris |
| Component: | Digital Clock | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | amichai2, kde, pip.kde, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.3.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Slackware | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/3e58a5210425dee72df80817c10133551f591acc | Version Fixed In: | 5.4.0 |
| Sentry Crash Report: | |||
| Attachments: | Default Plasma5 Digital Clock showing Date plus Time | ||
|
Description
sombragris
2015-05-21 15:55:12 UTC
*** This bug has been marked as a duplicate of bug 347724 *** On a second thought, this is not a duplicate of 347724. Sorry I misremembered what that bug was about. First off, thanks to Kai Uwe Broulik for the patch currently under review. https://git.reviewboard.kde.org/r/123877/ With regard to customisation of the font colour. Take the case of a transparent/semi-transparent panel with a dark desktop background or wallpaper behind, the ability to change the colour of the clock font would then be of great benefit. Personally I would like to see the ability to change it (as with KDE4), the reason being not one of aesthetics but of readability. > Take the case of a transparent/semi-transparent panel with a dark desktop background or wallpaper behind
In that case, you have more problems than just with the clock as /all/ Plasma text would be unreadable :) Such theme would be badly designed to start with.
On the other hand it is the theme's responsibility to ensure readability. If you cannot read the clock you most likely can't read the task manager entries or text in pop-ups either? Thanks to the "frosted glass" effect behind panels and dialogs, readability is significantly improved over 4.x OK. I'll wait and see on that one. My comment was based on previous experience with KDE4. Many thanks to you both. in the plasma 4 the date under the time is readable (see screenshot in bug #348078). In plasma 5, if you try adding the date to the default clock you can really see the difference - it's unreadable. (I'm not refering to iso-8601 formatting - there's a separate bug for that. but just the font, size and readability). > if you try adding the date to the default clock you can really see the difference
That highly depends on your font setting and panel height. Here it's perfectly readable and my panel has exact same pixel size as the one in the screenshot you referred to.
Mine is the default font/size, right after installation. What is the panel height you're using? and in what config file can I specify it to reproduce it? I did try enlarging the panel, but at the point at which the date became readable, the tray icons looked ridiculously large. Also what font/size are you using? Created attachment 92976 [details] Default Plasma5 Digital Clock showing Date plus Time (In reply to Martin Klapetek from comment #8) > > if you try adding the date to the default clock you can really see the difference > > That highly depends on your font setting and panel height. Here it's > perfectly readable and my panel has exact same pixel size as the one in the > screenshot you referred to. I'm guessing that "perfectly readable" is subjective ;) For comparison, this screen-shot is of a default, unaltered configuration, running plasma5 from the openSUSE latest (stable) Tumbleweed (http://download.opensuse.org/tumbleweed/iso/openSUSE-Tumbleweed-KDE-Live-x86_64-Snapshot20150602-Media.iso) Yeah, it's definitely subjective :-) I guess I was just comparing the snapshot in the issue I linked to with this one. To me, both the date and the time are much more readable in the former. I don't know where to check/set the exact pixel height of the panel for comparison. But the rest of the panel icons look find there, and when I change the height of my plasma 5 panel to the point where the clock looks similar, everything else becomes way too stretched. In the plasma 4 screenshot everything looks ok even when the clock time/date are big. Maybe it's just me :-) (In reply to Amichai Rothman from comment #11) > ... Maybe it's just me :-) No, don't think so :) Git commit 33395e8e4200a5d61e834cdd44a4088ef1b28e4b by Martin Klapetek. Committed on 03/08/2015 at 14:08. Pushed by mklapetek into branch 'master'. [digital-clock] Introduce new layouting state for small panels One of the most reported bugs wrt digital clock is that the second line text (date or timezone) is unreadable on small panels so this adds new state to the clock applet that lays things horizontally when the panel is too small to show text with the "small" font (set in system settings). When there is a date displayed, a delimiter is put in between to allow easier and faster spotting the time (as on a first glance there is just a bunch of numbers, so quickly orienteering is super important). I used the dot symbol first but then went for pipe which I think looks more clean. REVIEW: 124449 M +104 -6 applets/digital-clock/package/contents/ui/DigitalClock.qml http://commits.kde.org/plasma-workspace/33395e8e4200a5d61e834cdd44a4088ef1b28e4b Git commit 3e58a5210425dee72df80817c10133551f591acc by Kai Uwe Broulik. Committed on 05/08/2015 at 21:28. Pushed by broulik into branch 'master'. [digital-clock] Bring back font family option REVIEW: 123877 FIXED-IN: 5.4.0 M +3 -0 applets/digital-clock/package/contents/config/main.xml M +2 -0 applets/digital-clock/package/contents/ui/DigitalClock.qml M +66 -2 applets/digital-clock/package/contents/ui/configAppearance.qml http://commits.kde.org/plasma-workspace/3e58a5210425dee72df80817c10133551f591acc |