Bug 347983

Summary: kget fails to build using qt-5.5
Product: [Applications] kget Reporter: Christian Butcher <chrisb2244>
Component: CoreAssignee: KGet bugs <kget-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: https://commits.kde.org/kget/845570a2fadea4362e73a58c4a328c7bf7dc6e1a Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Patch to modify core/signature.h and cause make to succeed with qt5.5

Description Christian Butcher 2015-05-20 04:21:27 UTC 
kget fails to build using qt-5.5. Apparently this is due to a change in qtcore.
Can be fixed by explicitly including <QDataStream> in core/signature.h
Build error occurs in core/signature.cpp, but inclusion there leads to errors with the header. Since the header is included in the cpp file, one inclusion is sufficient for the .h file, but I don't know if the kde style would prefer explicit inclusion in both files.

Reproducible: Always

Steps to Reproduce:
1. Use qt-5.5 (I have the git sources for my build)
2. Switch to kf5_port in kget
3. Attempt to build kget on the kf5_port branch. 

Actual Results:  
cmake works but make fails with error 

core/signature.cpp:100:5 error: type 'QObject' is not a direct base of 'Signature' : QObject(object)

Expected Results:  
make succeeds.

Fixed by inclusion of <QDataStream>

Will add patch here.
Comment 1 Christian Butcher 2015-05-20 04:24:24 UTC 
Created attachment 92723 [details]
Patch to modify core/signature.h and cause make to succeed with qt5.5