Bug 347951

Summary: Notifications grow continuously (HiDPI)
Product: [Plasma] plasmashell Reporter: Diggory Hardy <kde2>
Component: NotificationsAssignee: Martin Klapetek <mklapetek>
Status: RESOLVED FIXED    
Severity: normal CC: adymo, fetzer.ch, kde, kde, kde_volle, nyblom, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.3.0   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Diggory Hardy 2015-05-19 14:16:07 UTC
When notifications first appear, they have (roughly) the correct size. But they don't stay that size; they grow continuously until they fill the whole screen (or are closed). This is a bit too annoying for my tastes!

I have a ~275 DPI screen with QT_DEVICE_PIXEL_RATIO=2 as well as adjusted font DPI.

Reproducible: Always
Comment 1 David Edmundson 2015-05-19 14:26:51 UTC
Yep seen this. Confirming.

That's partly why there's no GUI for setting that env var yet so to some extent it's not a super priority right now.
Comment 2 Kai Uwe Broulik 2015-05-19 15:40:46 UTC
The same happens with the panelcontroller advanced menu - seems whenever a dialog's size is bound to text, we get this behavior
Comment 3 Diggory Hardy 2015-06-16 10:36:57 UTC
Upgrading the priority. It makes the whole desktop nigh-unusable sometimes.
Comment 4 Kai Uwe Broulik 2015-06-16 17:18:54 UTC
Resetting priority, given we don't advertise support for this option yet (since it's not ready as you can tell) and we don't provide a GUI setting either.
Comment 5 David Edmundson 2015-07-26 11:02:38 UTC
Git commit 558e123d66f839ceb1ed32e25d04000f6cb38f5a by David Edmundson.
Committed on 26/07/2015 at 11:01.
Pushed by davidedmundson into branch 'master'.

Disable devicePixelRatio in PlasmaShell

Devive pixel ratio has some problems in plasmashell currently.

In particular:
- dialog continually expands (347951)
- Text element text is screwed (QTBUG-42606)
- Panel struts (350614)

It's also not a /huge/ deal as we do our own thing anyway, so the
experience is better to just turn off this scaling.

I've had this patch in my local code since forever.We should revert this
when all 3 are fixed.
REVIEW: 124463

M  +9    -0    shell/main.cpp

http://commits.kde.org/plasma-workspace/558e123d66f839ceb1ed32e25d04000f6cb38f5a
Comment 6 Volle 2015-07-27 13:55:49 UTC
so this means we dont have the scaling ability anymore after this patch?
With the bugs that come with it (growing notifictaions,...) it is annoying but without hte option kde isn't usable on my notebook at all.... 
So please don't just disable this ... If someone is bugged by the growing notifications he can just not use this env var ....
Comment 7 David Edmundson 2015-07-27 13:57:19 UTC
>so this means we dont have the scaling ability anymore after this patch?
No.
Comment 8 David Edmundson 2015-08-07 21:47:04 UTC
Git commit b932fe461a555f09886d577f734e6d6624654f76 by David Edmundson.
Committed on 07/08/2015 at 21:43.
Pushed by davidedmundson into branch 'master'.

Handle clients having a different device pixel ratio

Qt scales down the size of QScreens by the device pixel ratio; we should
make our windowing APIs match.

X (and KWin) deal with device dependent pixels, so everything needs to
be converted when communitcating geometry.

Abstraction happens in the main kwindowsystem so X and Wayland are both
supported.
Related: bug 350865, bug 350614
REVIEW: 124648

M  +20   -9    src/kwindowsystem.cpp

http://commits.kde.org/kwindowsystem/b932fe461a555f09886d577f734e6d6624654f76