Bug 347750

Summary:	ksshaskpass cannot remember more than one single passphrase
Product:	[Applications] ksshaskpass	Reporter:	Marc Schiffbauer <mschiff>
Component:	general	Assignee:	Jeremy Whiting <jpwhiting>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	kbugs, postix
Priority:	NOR
Version:	5.3.0
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Remove comment from command line argument

Description Marc Schiffbauer 2015-05-15 08:33:45 UTC

kssaskpass works only as far as you only have one ssh-key or maybe more keys with the same passphrase, but not with different passphrases.

I have two ssh keys (dsa and rsa) with different passphrases. I will be asked for both passphrases on login, but by checking the "remebmer password" checkbox in the passphrase dialog the passphrases will overwrite each other.

Reproducible: Always

Steps to Reproduce:
1. Have two different ssh keys with different passphrases
2. Make ssh-add (ssh-add -c in my case) add the on login
3. Use checkbox "remember password"


Actual Results:  
you will be asked for the first passphrase again on next login if you checked the checkbox on the second key and vice versa.

Expected Results:  
ksshaskpass should remember for which kind of key a passphrase was so it could remember differetn ssh passphrases.

Comment 1 kbugs 2017-06-29 16:56:48 UTC

Created attachment 106373 [details]
Remove comment from command line argument

When you use "ssh-add -c" to add a key file, ksshaskpass is called with an argument like "Enter passphrase for filename (will confirm each use):". Because ksshaskpass uses the last word as file name, it places an entry for "use)" in the wallet.

My patch removes all text in parentheses from the command line argument before taking the last word as file name.

Comment 2 Christoph Feck 2017-06-29 21:44:04 UTC

The patch is for ksshaskpass 5.8. Please check if this issue is also visible with version 5.10.3, because the way prompts are parsed has been rewritten.

Comment 3 kbugs 2017-06-30 16:50:32 UTC

I can confirm that v5.10.3 works perfectly. Thank you very much!

Comment 4 postix 2021-05-08 13:06:50 UTC

(In reply to kbugs from comment #3)
> I can confirm that v5.10.3 works perfectly. Thank you very much!

So can this be closed? :)

Comment 5 Bug Janitor Service 2021-05-23 04:33:40 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 6 Bug Janitor Service 2021-06-07 04:33:35 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!