Bug 346972

Summary:	Star rating icons in amarok always black with breeze theme
Product:	[Plasma] Breeze	Reporter:	Evert Vorster <evorster>
Component:	general	Assignee:	Plasma Development Mailing List <plasma-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jamboarder, kde, michel.poleur, myriam
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Bug Depends on:	339863
Bug Blocks:

Description Evert Vorster 2015-04-30 18:06:34 UTC

The star ratings in Amarok is always black in the breeze theme, but works fine in the Oxygen theme. 



Reproducible: Always

Steps to Reproduce:
1.Apply Breeze theme.
2.Open Amarok
3.Try to rate a song

Actual Results:  
Stars stay black

Expected Results:  
Expect yellow stars showing when clicking on them

Just noticed this when upgrading to Plasma desktop on Arch, and installed breeze theme with it.

Comment 1 Evert Vorster 2015-04-30 18:07:28 UTC

This bug was reported against Amarok with number 346711, but it was claimed that this is not an Amarok bug, as it works fine in Oxygen theme

Comment 2 Andrew Lake 2015-04-30 18:24:03 UTC

Fixed in 5.3 (commit 89d85cc3a)

*** This bug has been marked as a duplicate of bug 339863 ***

Comment 3 Christoph Feck 2015-04-30 19:48:49 UTC

Amarok is a KDE4 application, so it's not fixed.

*** This bug has been marked as a duplicate of bug 346625 ***

Comment 4 David Edmundson 2015-04-30 19:50:21 UTC

kdelibs is still getting releases, 
Christoph is it worth backporting your change?

Comment 5 Christoph Feck 2015-04-30 20:06:46 UTC

The change apparently does not work :/

Comment 6 Andrew Lake 2015-04-30 20:30:00 UTC

Sorry, I maybe should not have marked this as duplicate. Let me explain.

The problem for the Breeze icon theme is that the rating icon was monochrome black (Icon Grey technically). This was reported earlier against Breeze in bug 339863. During that bug review it was decided to re-assign it to KRatingPainter and Christopher Feck attempted to update KRatingPainter to improve how it handles monochrome low-saturation icons.  Unfortunately, despite Christopher's effort, it somehow didn't work out. So the Breeze icon theme was updated to use a yellow icon, which is similar to oxygen and so should work similar to Oxygen.

So while the problem is technically RESOLVED-FIXED for Breeze, KRatingPainter might still have a little trouble with monochrome low-saturation icons until we figure out why Christopher's patch didn't seem to work.

I'll change this to fixed for Breeze here. Hrvoje Senjan has already re-opened the KRatingPainter bug 339863. If that bug gets resolved then we can update the icon theme to take advantage of the fix to provide an even more distinct full vs empty rating star icon.

Hope this helps.