Bug 346680

Summary: Untranslatable strings in Comment column
Product: [Plasma] plasmashell Reporter: André Marcelo Alvarenga <alvarenga>
Component: Digital Clock widgetAssignee: Martin Klapetek <mklapetek>
Status: RESOLVED FIXED    
Severity: normal CC: aspotashev, karl, kde, lueck, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: 5.2.90   
Target Milestone: 1.0   
Platform: Kubuntu   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description André Marcelo Alvarenga 2015-04-26 01:50:48 UTC 
In Time Zone page there are various untranslatable strings.

Examples: South Australia, most locations, Alaska Time

Reproducible: Always
Comment 1 Burkhard Lück 2015-04-26 12:57:40 UTC 
Untranslatable are all entries in column "Comment" except the string "Your system time zone"
Comment 2 Martin Klapetek 2015-04-26 16:54:29 UTC 
Those strings come from Qt directly and the source is tzdata (I think). I was under the impression that tzdata also carries translations? And correct one is returned by Qt according to locale, is that not the case?
Comment 3 Kai Uwe Broulik 2015-04-26 16:55:38 UTC 
From what I can tell QLocale sucks at translations; it can only give you country name in English or the local language, not in your current language. Wouldn't surprise me if it cannot handle timezone names properly either.
Comment 4 Burkhard Lück 2015-04-27 08:00:33 UTC 
(In reply to Martin Klapetek from comment #2)
> Those strings come from Qt directly and the source is tzdata (I think).

No, the translation for the strings in columns "City" and "Region" come from digital-clock/plugin/timezonesi18n.cpp introduced with https://git.reviewboard.kde.org/r/120353/ by Martin Klapetek
I'd say the strings for column "Comment" are missing in timezonesi18n.cpp
Comment 5 Martin Klapetek 2015-04-27 08:30:25 UTC 
Ah yes, I totally forgot about that :D

The strings for the Comment however can change with every tzdata update (that's the source of those, if I'm not mistaken again), which would make it a moving target. But if that's not a problem, I could add those with my current tzdata.

Alternatively, we can just remove it altogether maybe?
Comment 6 Karl Ove Hufthammer 2015-10-23 06:22:18 UTC 
I don’t think the comment field should be removed altogether. It provides useful information. For example, if you live in Newfoundland, a search for ‘Newfoundland’ will find your appropriate time zone (or it will, when #354238 is fixed), but ‘Newfoundland’ is only mentioned in the comments, not in the time zone name (‘St Johns’).
Comment 7 Nate Graham 2020-10-18 14:40:07 UTC 
Well, the Comments column was eventually removed (in 5.20 IIRC) so this shouldn't be a problem anymore.