Summary: | Remove 1px margin [patch included] | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Josef Kufner <jk> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | cpigat242, nils.luxton |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/konsole/8e5a5b1ec1fb68e359319c9ce23a43c0434b836a | Version Fixed In: | |
Attachments: | Add profile option to set margin and centering instead of hardwired values |
Description
Josef Kufner
2015-04-21 22:27:25 UTC
The margin is intended to improve readability of black letters (on bright background) at screen edges. I also found (in source code, the next line -- setCenterContents()) an option to center the view within window, which makes it look much better. Well, the best would be to include these options in profile settings dialog :) Created attachment 95741 [details]
Add profile option to set margin and centering instead of hardwired values
This patch add profile options to set margin in pixels and enable/disable centering.
Defaults are same as original hardwired valuse, but now it is possible
to change them via editing profile file:
[General]
TerminalMargin=1
TerminalCenter=false
There is no user interface to change these values for now.
Is there any proposal for when this might be merged? let me look at it and see if I can get it in for next release That would be great, thanks. I'm not concerned with it having a UI (personally) but understand if that is a 'blocker' to getting this in. My use case is in fact the opposite of the OP, namely, to be able to center and increase the margin. Git commit 8e5a5b1ec1fb68e359319c9ce23a43c0434b836a by Kurt Hindenburg. Committed on 17/09/2016 at 01:57. Pushed by hindenburg into branch 'master'. Allow profile to set margin and center flag These 2 were hard coded - this allow them to be set in the profile. There is currently no UI for these; add these to profile: [General] TerminalMargin=1 TerminalCenter=false Thanks to Josef Kufner jk frozen doe net for patch It appears the center flag doesn't work and perhaps hasn't for a long time. M +4 -0 src/Profile.cpp M +14 -0 src/Profile.h M +3 -0 src/TerminalDisplay.cpp M +3 -3 src/ViewManager.cpp http://commits.kde.org/konsole/8e5a5b1ec1fb68e359319c9ce23a43c0434b836a |