Bug 346431

Summary:	Wallpaper and Mouse Actions doesn't show a dialog when we are changing the category.
Product:	[Plasma] plasmashell	Reporter:	Antonis Tsiapaliokas <antonis.tsiapaliokas>
Component:	Image & Slideshow wallpaper plugins	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	normal	CC:	plasma-bugs
Priority:	NOR
Version:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-desktop/8d6a08416f95ce8b346d205fd4bdab3692ce24de	Version Fixed In:
Sentry Crash Report:

Description Antonis Tsiapaliokas 2015-04-21 14:58:30 UTC

I have prepare a patch for this bug.

Reproducible: Always

Steps to Reproduce:
1. Open Desktop settings
2. Make some change in the Wallpaper or in the Mouse Actions
3. Change the category. 

Actual Results:  
The message dialog should shown it self.

Expected Results:  
Nothing happens. We are just changing category.

Comment 1 Antonis Tsiapaliokas 2015-04-21 15:04:45 UTC

Here is the ticket for the rb.

https://git.reviewboard.kde.org/r/123448/

Comment 2 Antonis Tsiapaliokas 2015-04-21 20:30:03 UTC

Git commit 8d6a08416f95ce8b346d205fd4bdab3692ce24de by Antonis Tsiapaliokas.
Committed on 21/04/2015 at 20:26.
Pushed by tsiapaliokas into branch 'master'.

Message dialog should always show if we have any pending changes.

REVIEW: 123448

M  +0    -19   desktoppackage/contents/configuration/AppletConfiguration.qml
M  +2    -2    desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

http://commits.kde.org/plasma-desktop/8d6a08416f95ce8b346d205fd4bdab3692ce24de