Bug 346419

Summary: Images in the notifications appear over the grey border
Product: [Plasma] plasmashell Reporter: Artur Frącek <artur>
Component: NotificationsAssignee: Martin Klapetek <mklapetek>
Status: RESOLVED FIXED    
Severity: normal CC: kdelibs-bugs, plasma-bugs
Priority: NOR    
Version: master   
Target Milestone: 1.0   
Platform: Kubuntu   
OS: Linux   
URL: http://i.imgur.com/WSiW6DI.png
Latest Commit: http://commits.kde.org/plasma-workspace/f9324e874e8a57ae1f8d82e45274d591ad1adab9 Version Fixed In: 5.3.1

Description Artur Frącek 2015-04-21 01:24:38 UTC 
When using mumble on Kubuntu 15.04 with plasma5 I noticed that when some sends a message with an image in it in the notification part of the image appears over the 1px grey border around it which makes it look odd.

Reproducible: Always

Steps to Reproduce:
1. Start mumble and connect to a server
2. Get someone to send an image in the chat
3. Look at the notifications

Actual Results:  
The image covers the grey 1px border around the notification

Expected Results:  
The image should be displayed with at least 1px margin on the right and bottom

I often hang out at mumble.jupitercolony.com:64734 if you need help replicating the bug.
Comment 1 Martin Klapetek 2015-04-21 10:17:43 UTC 
Whoaa, that's....bad. Thanks for the report.

Which Plasma version this is?
Comment 2 Artur Frącek 2015-04-21 16:24:05 UTC 
(In reply to Martin Klapetek from comment #1)
> Whoaa, that's....bad. Thanks for the report.
> 
> Which Plasma version this is?

kf5.kiconthemes: "Theme tree: (Breeze)"
plasmashell 5.2.2
Comment 3 Martin Klapetek 2015-05-14 10:17:59 UTC 
Git commit 29e5f42ba1701a694a731ab3fafef907d561fa4b by Martin Klapetek.
Committed on 14/05/2015 at 10:17.
Pushed by mklapetek into branch 'Plasma/5.3'.

[notifications] Clip the NotificationItem to prevent painting outside of its rect

As notifications support <img/> tags, it can happen that a big image is
sent and that is then painted even outside of the popup's frame. So we
need to clip it.
FIXED-IN: 5.3.1

M  +3    -0    applets/notifications/package/contents/ui/NotificationItem.qml

http://commits.kde.org/plasma-workspace/29e5f42ba1701a694a731ab3fafef907d561fa4b
Comment 4 Lukáš Tinkl 2015-05-18 16:37:21 UTC 
Git commit f9324e874e8a57ae1f8d82e45274d591ad1adab9 by Lukáš Tinkl, on behalf of Martin Klapetek.
Committed on 15/05/2015 at 00:54.
Pushed by lukas into branch 'ltinkl/solid-power'.

[notifications] Clip the NotificationItem to prevent painting outside of its rect

As notifications support <img/> tags, it can happen that a big image is
sent and that is then painted even outside of the popup's frame. So we
need to clip it.
FIXED-IN: 5.3.1

M  +3    -0    applets/notifications/package/contents/ui/NotificationItem.qml

http://commits.kde.org/plasma-workspace/f9324e874e8a57ae1f8d82e45274d591ad1adab9