Bug 346138

Summary: color range selector fails to select lower part of the same color
Product: [Applications] krita Reporter: guruguru.sp
Component: Color SelectorsAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla, kalia24, sven.langkamp
Priority: NOR    
Version: 2.9.1   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/krita/a4fb987d589deea53af9d9609f1a78d076b6d59f Version Fixed In:
Sentry Crash Report:
Attachments: Color Selection fail

Description guruguru.sp 2015-04-13 12:16:25 UTC 
Color range selector fails to select lower part of the exact same color. It looks like the selection seems to be cut off horizontally.

Reproducible: Always

Steps to Reproduce:
1. Create a new file
2. Draw a filled rectangle of a specific color
3. Use color range select 

Actual Results:  
Lower part of the colored rectangle area does not get selected.

Expected Results:  
All of the colored rectangle area will be selected.

This does not seem to happen when canvas is fairy small(400x400). Krita2.9.2, Windows 8.1.
Comment 1 guruguru.sp 2015-04-13 12:17:17 UTC 
Created attachment 92010 [details]
Color Selection fail
Comment 2 Halla Rempt 2015-04-16 09:23:54 UTC 
Hi!

Thanks for your report. I can confirm the bug indeed.
Comment 3 kalia24 2018-07-15 19:29:28 UTC 
Confirm on Win7 and Krita 4.1.
Comment 4 Sven Langkamp 2018-10-09 21:10:52 UTC 
Can't reproduce with master and Linux.
Comment 5 Halla Rempt 2018-11-30 10:11:26 UTC 
Git commit 5a2eced9fcdc7ebadb1f2b9681eae3631458bda5 by Boudewijn Rempt.
Committed on 30/11/2018 at 10:10.
Pushed by rempt into branch 'master'.

Select by color range: iterate over the image, not the device

M  +2    -1    plugins/extensions/colorrange/dlg_colorrange.cc

https://commits.kde.org/krita/5a2eced9fcdc7ebadb1f2b9681eae3631458bda5
Comment 6 Halla Rempt 2018-11-30 10:11:37 UTC 
Git commit a4fb987d589deea53af9d9609f1a78d076b6d59f by Boudewijn Rempt.
Committed on 30/11/2018 at 10:11.
Pushed by rempt into branch 'krita/4.1'.

Select by color range: iterate over the image, not the device

M  +2    -1    plugins/extensions/colorrange/dlg_colorrange.cc

https://commits.kde.org/krita/a4fb987d589deea53af9d9609f1a78d076b6d59f