Bug 346121

Summary:	KCMs do not respect setting "Show icons on buttons" in Widget Style
Product:	[Applications] systemsettings	Reporter:	Thomas Pfeiffer <thomas.pfeiffer>
Component:	general	Assignee:	Unassigned bugs <unassigned-bugs-null>
Status:	CLOSED FIXED
Severity:	normal	CC:	kde, nate
Priority:	NOR
Version First Reported In:	5.2.95
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Thomas Pfeiffer 2015-04-12 22:58:47 UTC

There is a checkbox "Show icons on buttons" in Widget Style. this setting is respected by both kde4 and KF5-based applications, but not by KCMs (regardless of whether they's started from kcmshell or standalone).

Reproducible: Always

Steps to Reproduce:
1. Go to Systemsettings -> Application Style -> Widget Style -> Fine Tuning
2. Uncheck "Show icons on buttons"
3. Restart Systemsettings
4. Open any KCM

Actual Results:  
Buttons still have icons

Expected Results:  
Buttons do not have icons

This bug was present since at least 5.2, so it's not a regression.

Comment 1 David Edmundson 2015-04-12 23:07:55 UTC

probably not following the hint QStyle::SH_DialogButtonBox_ButtonsHaveIcons

Comment 2 Christoph Feck 2019-02-08 14:11:46 UTC

Cannot reproduce since a long time.

Comment 3 Thomas Pfeiffer 2019-04-23 15:14:44 UTC

I can confirm that the setting is respected by KCMs now.