| Summary: | [Regression] Kickoff is not mounting removable devices and shows "Invalid URL" error | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Konrad Materka <materka> |
| Component: | Application Launcher (Kickoff) widget | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | materka, notmart, plasma-bugs |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-desktop/49a1a2827639b3099a2f16fc3c8eef6130e4d95d | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | use openItem instead of openUrl | ||
|
Description
Konrad Materka
2015-04-08 22:18:36 UTC
Created attachment 91958 [details]
use openItem instead of openUrl
need to be applied in plasma-desktop/applets/kickoff
FYI, we tend to use http://git.reviewboard.kde.org for patches. I can take this from here if you like, but it's useful to know for future code contributions. Why the change to set a VisualDelegateModel? it can't be in order to use the modelIndex method as the existing code used that already I don't have account on Review Board, please move it from here. In meantime I need to find a way how to get LDAP account ;) Why VisualDelegateModel? It may be workaround/hack/you name it but it was the only way I found acceptable. You need to pass QModelIndex to openItem and I don't know how to get it using plain ListView and SystemModel. VisualDelegateModel has a convenience method modelIndex which is already used in KickoffItem.qml (but only if ApplicationsView tab is active). I changed BaseView to use VisualDelegateModel to have modelIndex method and to be more consistent with ApplicaitonView. I don't know if it has side effects, think about this as a proof of concept. Of course I could change openItem and pass url and udi instead of QModelIndex but this doesn't look right - openItem method should get only... item (or item's model) and get required data internally. PS. I'm from Java world, I have little experience with Qt (3/4) and never used Qt Quick and QML. I uploaded the patch here: https://git.reviewboard.kde.org/r/123350/ btw, if you plan of submitting other patches, you would be very welcome! btw locally here can't reproduce, removable drives gets mounted fine Patch makes more harm than good... I'll retest latest GIT code today and check if it is working - maybe it was fixed in meantime. If not I'll prepare test case with some log etc. Marco, I was able to reproduce using latest GIT code. Screenshots, first shows not mounted removable device, second is error message (in Polish): https://www.dropbox.com/s/8vcokx17kmn3onw/zrzut%20ekranu1.png?dl=0&s=sl https://www.dropbox.com/s/sqkci1z1fhb3h3p/zrzut%20ekranu2.png?dl=0&s=sl In console I can find this message: Opening item with URL "" I looks that KFilePlacesModel->url(index) returns empty string for not mounted devices. I have 5.9.0 version of libkf5kiocore5 installed. New, fixed patch: https://git.reviewboard.kde.org/r/123426/ Last one broke Favourites View. Git commit 49a1a2827639b3099a2f16fc3c8eef6130e4d95d by Marco Martin. Committed on 12/05/2015 at 09:26. Pushed by mart into branch 'master'. Fix removable devices mounting in Kickoff use openItem instead of openUrl patch by Konrad Materka REVIEW:123426 M +10 -0 applets/kickoff/core/systemmodel.cpp M +7 -3 applets/kickoff/package/contents/ui/BaseView.qml M +9 -4 applets/kickoff/package/contents/ui/KickoffItem.qml http://commits.kde.org/plasma-desktop/49a1a2827639b3099a2f16fc3c8eef6130e4d95d |
