Bug 345919

Summary:	Bookmark icons use absolute paths in any case
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Akshat Tandon <akshat.tandon>
Status:	RESOLVED FIXED
Severity:	minor	CC:	akshat.tandon
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Bookmark chooser dialog.

Description Dennis Nienhüser 2015-04-06 13:33:19 UTC

In https://git.reviewboard.kde.org/r/121665 a customization of bookmark icon paths was added. Now the icon of bookmarks is saved along with the bookmarks file by specifying an absolute path to the icon image, even for the default case. There are a couple of downsides with this approach
- if the installation directory is changed e.g. by the distribution, all user bookmark icons will break
- if we change the path to the default bookmark icon or its name, all user bookmark icons will break
- there is no support for icons loaded via qrc, which is important e.g. for diskless systems

I'd suggest an improved version which
- provides a couple of standard bookmark icon variants in a well-known qrc subfolder. E.g. qrc:/marble/bookmarks/bookmark_red.png, qrc:/marble/bookmarks/bookmark_yellow.png, ...
- has a list view or similar that displays those icons in the dialog for easy selection by the user
- optionally allows to insert further user-defined icons which could then use absolute paths to file system locations

Comment 1 Akshat Tandon 2016-01-10 21:28:35 UTC

I want to work on this feature and hence want clarification on a few things.
1. How should this new list of predefined icons be shown to the user, should I add a combo box below the icon path using which a user can select one of the predefined icons or should I add a button which on being clicked opens a new dialog showing the predefined icons.
2. Should I retain the existing way of adding a custom icon ( by clicking on the icon image to select an image file) or should I remove it and add "Custom"  as one of the options of combo box. In case the icon selection is via a dedicated dialog window should I add a custom button in this dialog along with the list of all predefined icons.
3. When a user adds a custom icon image for a particular bookmark should this new icon be saved in the predefined icon list for future references or not?

Comment 2 Akshat Tandon 2016-01-12 22:54:55 UTC

Created attachment 96614 [details]
Bookmark chooser dialog.

I have submitted a patch for this here
https://git.reviewboard.kde.org/r/126729/

Comment 3 Dennis Nienhüser 2016-04-02 06:24:47 UTC

Fixed in Applications/16.04 and later.