Bug 345896

Summary:	taks widgets ignore style hints in /widget/tasks.svg(z)
Product:	[Plasma] plasmashell	Reporter:	FabiB <plusfabi>
Component:	Task Manager and Icons-Only Task Manager widgets	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	lemmyg, nate, notmart, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.2.2
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	the ame element on north and east. that should not be tasks element for testing.

Description FabiB 2015-04-05 18:24:38 UTC

for my theme i need to set different top/bottom and left/right margins for elements in west, east, south and north. 
icon only tasks and the normal task manager just ignore all style elements in west, east, and north. it uses only the "normal-hint-*-margin" element, wich is a bug that should be fixed, to make better themes possible.

Reproducible: Always

Comment 1 FabiB 2015-04-05 18:26:18 UTC

Created attachment 91898 [details]
the ame element on north and east. that should not be

on the first attachment you can see that there are the same height/width for bot - north and east elements. that is because of the bug

Comment 2 FabiB 2015-04-05 18:28:28 UTC

Created attachment 91899 [details]
tasks element for testing.

the secound attachment is a tasks.svg, you can use to try the bug, because in breeze itself all elements on every side are the same, so that the wont dont appear there.

Comment 3 Eike Hein 2015-04-05 23:29:19 UTC

There's unfortunately a lot of historical baggage here. The old Plasma Task Manager, from before my rewrite, already behaved this way, and as a result there are countless themes that rely on this behavior and don't specify sensible margins for the non-normal states, causing the button contents to shift around in an ugly way if they're respected. So while you're correct that this is technically incorrect and I would greatly prefer for it to behave in the way you desire, our hands are also kind of tied. What we could do is define an additional hint element to allow themes to opt into the correct behavior.

Comment 4 FabiB 2015-04-06 00:15:19 UTC

maybe some kind of global hint, like "plasma5-only-hint". this way it would be possible to fix some other errors too without a compatibility loss for older themes? i really like the idea. Because right now the theming possibilies for plasma are in a really bad state :(

Comment 5 Eike Hein 2015-04-06 11:57:58 UTC

I'll brain-storm this a bit with Marco Martin after we freeze 5.3 this week and we'll figure out what we can do for 5.4.

Comment 6 FabiB 2015-04-06 12:04:56 UTC

Thank you so much for this! :)

Comment 7 Marco Martin 2015-04-07 08:25:31 UTC

I don't think it is a problem to use like east-hint-bottom-margin and such if available, since old themes would not have those elements at all, so shouldn't change behavior..

Comment 8 galder 2022-01-30 16:04:11 UTC

Looks like an old issue. Setting it to needs more info.
Please try with a newer version(plasma 5.23.5) and if this is not an issue any more let us know.
Bugs placed into NEEDSINFO status will receive a reminder if the ticket:

    Is at least 15 days old
    Has not received any comment within 15 days

If a bug remains in NEEDSINFO for another 15 days with no comment, it will be closed as RESOLVED > WORKSFORME.
If a bug remains in NEEDSINFO with a comment provided within less than 15 days, no action will be taken (as it does not meet the above criteria).

Comment 9 Nate Graham 2022-01-30 19:44:55 UTC

Pretty sure this is in fact fixed now.