Bug 345866

Summary:	Version Krita 2.9.2: Edit Brush Settings: Overwrite Preset Button Glitches
Product:	[Applications] krita	Reporter:	Jonathan <contact>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, scottpetrovic
Priority:	NOR	Keywords:	usability
Version First Reported In:	2.9
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jonathan 2015-04-04 13:39:45 UTC

I have designed my own presets with bespoke-self-made brush predefined tips.  Manipulating the original brush presets appear to be working accordingly with the Overwrite Preset Button becoming active after preset options have been altered. However some of my manipulated/bespoke brushes seem to have a permanent grey out button for 'Overwrite Preset', regardless of manipulations to options and predefined tip selections. This tends to deviate from brush to brush every-time I relaunch Krita. In addition the problem arisen when I opened another document to make a preset predefined tip while creating an image for my patterns work in another opened document.

Reproducible: Always

Steps to Reproduce:
1.Alter size and rotation in manipulated brush preset, under General in 'Edit Brush Settings'
2.Overwrite Preset Button greys out despite alteration.
3.Press 'Reload Original Preset', but to no avail.


Actual Results:  
When manipulated the results appear as I use the brush, but I can not alter brush name or save changes, to create another preset from manipulated bespoke preset. I have to make the manipulations from the original brushes that come with the Krita installation to make new brushes and alterations. 

Expected Results:  
Everything time a manipulation to a brush preset is created, I expect the 'Overwrite Preset Button' to come active from greyed out to make changes. Please note: 'Temporary Save Tweaks To Presets' is off and not active when making these changes.

Comment 1 Jonathan 2015-04-04 15:20:46 UTC

Please note: That I have recently performed some additional tests and found that the Krita 2.9.2 Brush Presets works accordingly on Windows 7 Operating System and there are no 'Edit Brush Settings' anomalies. The system that I am using for my main machine is Windows 8.1 and that seems to be the source of the conflict. Please be aware that both operating systems that I'm using are 64 bit.

Comment 2 Jonathan 2015-04-06 15:29:25 UTC

I have researched into the problem, I downloaded bundles from my computer with OS-Windows 8.1, and uploaded them onto my version of Krita, on my old machine (with an OS Windows 7), - It appears that the bundles themselves are corruptible. The main problem comes from the predefined brush tips. When creating a new bundle to save the corrupted tips- the bundle appears blank. In order to test the bundles I wiped all roaming data in my C drive from 'krita\share\apps\krita\bundles'- under my users folder. 

The results told a story:
- the tips were fine when initially uploaded from 'Managed Resource Bundles'- Bundles were created before corruption- on Windows OS 7.(from old machine).
- then the Overwrite Preset Button failed to work- OS Windows 8.1-New Machine
- the bundles were deleted from the C Drive-under my Users Folder
- Krita re-opened
- Then I uploaded newly created bundles from 'Managed Resource Bundles' under Settings
-Predefined Tips-missing... All tips were meticulously selected when creating Bundles for the 'Brushes'-section above 'Brush Presets'. 

-Conclusion/Idea behind corruption: Conflicts appear with the tips in Windows 8.1 and corrupts the predefined brush files.- This is how it appears from my Operating Systems- both computer have been checked and scrutinized for errors.

Comment 3 Halla Rempt 2016-03-19 14:11:39 UTC

Hi Jonathan,

Sorry for the late response. I can confirm that there are various problems with the preset handling :-(. We really need to sit down and debug this.

Comment 4 Scott Petrovic 2017-09-13 15:41:35 UTC

In Krita 4.0, the brush saving has been updated quite a bit. It is now called  "Overwrite Brush" and saves over the current brush preset with the existing thumbnail.

I also did some changes to the dirty (changed) state and how the Overwrite button is enabled. I followed the original steps to reproduce in the ticket and it appears to be working now. The reset button is on top now.

There has also been quite a bit of work done to the bundles, since this ticket was filed. If there are still issues with this, it might be easier to open up another ticket.

I would try to use a 4.0 build if possible when testing brushes or bundles.