Bug 345387

Summary:	lens auto-correction tools shows "partial mathc" for canon 700d 18-135 is stm
Product:	[Applications] digikam	Reporter:	Kostya <voroninkv>
Component:	Plugin-Editor-LensCorrection	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	4.8.0
Target Milestone:	---
Platform:	Slackware
OS:	Linux
Latest Commit:		Version Fixed In:	4.9.0
Sentry Crash Report:
Attachments:	example lens auto-correction screenshot metadata screenshot full exif copy from digikam editor.

Description Kostya 2015-03-21 09:36:27 UTC

When trying to do lens auto correction using metadata only "make" and "model" is detected. 
"(partial match found)" is shown.
Next I can select correct lens from drop-down list.
I use lensfun version 0.3.0


Reproducible: Always

Steps to Reproduce:
1. open file for edit
2. select "enhence->lens->auto-correction


Actual Results:  
make, model detected, lenses don't match

Expected Results:  
make, model, lens detected

I use lensfun version 0.3.0

Comment 1 Kostya 2015-03-21 09:41:28 UTC

Created attachment 91662 [details]
example

Comment 2 caulier.gilles 2015-03-21 12:25:41 UTC

next digiKam 4.9.0 will intrude some improvements in this tool done by MAik Qualmann.

Can you share images to try to reproduce in local ?

Gilles Caulier

Comment 3 Kostya 2015-03-21 18:50:27 UTC

Great to new, about upcoming improvements.
I added one image as example, and can share more if needed.

Comment 4 Maik Qualmann 2015-03-21 19:06:23 UTC

Your test image is recognized in digikam 4.9.0 for exact match. But I have tested it with the 4.8.0 version (OpenSUSE version) and even there it is already recognized for exact match. It should work with the 4.8.0 version so already. Can you make a screen shot from the right side bar.

Maik

Comment 5 Kostya 2015-03-21 19:16:28 UTC

Created attachment 91668 [details]
lens auto-correction screenshot

Comment 6 Kostya 2015-03-21 19:22:31 UTC

may be it's my configuration/build issue, but I can't figure how can I check or test this.

Comment 7 Kostya 2015-03-21 19:30:01 UTC

Created attachment 91669 [details]
metadata screenshot

I notice that there is no space between "EF-S" and "18"
"EF-S18-135mm f/3.5-5.6 IS STM"

Comment 8 Maik Qualmann 2015-03-21 19:46:05 UTC

Your lens is from the Exif only 18.0 - 135.0 mm recognized. Exists under Makernote -> CanonCs the entry "Lens Type" with the correct name of the lense? After the metadata screenshot, the entry does not exist. Which version of Exiv2 is installed?

Maik

Comment 9 Kostya 2015-03-21 20:04:46 UTC

Created attachment 91670 [details]
full exif copy from digikam editor.

I use Exiv2 - 0.23. And will try 0.24

Comment 10 Kostya 2015-03-21 22:58:59 UTC

after upgrading Exiv2 to 0.24 problem gone. 
Thanks for help. Should I close this ticket?