Bug 345367

Summary:	The sideview containing the thumbnails is not updated after deleting a photo
Product:	[Applications] digikam	Reporter:	alphsteiner
Component:	Showfoto-Thumbs	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	critical	CC:	caulier.gilles, metzpinguin, mohammed.ahmed.anwer
Priority:	NOR
Version:	4.8.0
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/1f3b72d30df31a024c97c15828542b8e8db66029	Version Fixed In:	4.9.0
Attachments:	showfotodelete.patch

Description alphsteiner 2015-03-20 18:31:45 UTC

After deleting a photo (using the delete key), the sideview is not updated and the photo is still shown when clicking on the thumbnail. Another delete operation reports a 'file does not exist' error message, since the photo has been deleted on the disk.

Reproducible: Always




This bug is critical since it makes you lost the track of what has been deleted and what is not, and can lead to a lost of photos if you do not realise the problem immediatly.

Comment 1 caulier.gilles 2015-03-20 19:31:40 UTC

Mohamed,

It's reproducible on your computer ?

Gilles

Comment 2 alphsteiner 2015-03-21 12:18:18 UTC

For information, I have checked that I can reproduce this bug on virtual machines with both fedora 20 & 21: the thumbnail sideview is never updated after a deletion. 
The version in use is 4.8.0.

Comment 3 Mohamed 2015-03-21 12:37:49 UTC

Yes, it is reproducible

Comment 4 Maik Qualmann 2015-03-21 18:52:14 UTC

Created attachment 91666 [details]
showfotodelete.patch

This patch enabled code and adds needed functions. The missing functions was taken from the ImageModel or ImportImageModel.

Maik

Comment 5 caulier.gilles 2015-03-22 08:05:53 UTC

Git commit 1f3b72d30df31a024c97c15828542b8e8db66029 by Gilles Caulier.
Committed on 22/03/2015 at 08:04.
Pushed by cgilles into branch 'master'.

apply patch #91666 from Maik Qualmann to fix issue in Showfoto thumbnails when item is deleted.
FIXED-IN: 4.9.0

M  +3    -1    NEWS
M  +1    -1    showfoto/main/showfoto.cpp
M  +37   -1    showfoto/thumbbar/showfotoimagemodel.cpp
M  +5    -2    showfoto/thumbbar/showfotoimagemodel.h

http://commits.kde.org/digikam/1f3b72d30df31a024c97c15828542b8e8db66029

Comment 6 caulier.gilles 2015-03-22 08:52:55 UTC

Git commit afb2d59644193b696bb61b3e377af28b21b7e1fb by Gilles Caulier.
Committed on 21/03/2015 at 17:53.
Pushed by cgilles into branch 'frameworks'.

backport commit #1f3b72d30df31a024c97c15828542b8e8db66029 from git/master to frameworks branch

M  +1    -1    showfoto/main/showfoto.cpp
M  +37   -1    showfoto/thumbbar/showfotoimagemodel.cpp
M  +5    -2    showfoto/thumbbar/showfotoimagemodel.h

http://commits.kde.org/digikam/afb2d59644193b696bb61b3e377af28b21b7e1fb