| Summary: | digiKam crash when vkontakte plugin failed to upload images | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Vaso <fuckel> |
| Component: | Plugin-WebService-Vkontakte | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | aspotashev, caulier.gilles |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/libkvkontakte/631f6bb19c9045ab9ef0d4c1a83d6b700cf7138f | Version Fixed In: | 4.11.0 |
| Sentry Crash Report: | |||
|
Description
Vaso
2015-03-20 12:34:35 UTC
(In reply to fuckel from comment #0) > Get error messages about wrong album id. Please tell me what the error message looked like exactly. Did it appear as a dialog box? Yes, it is a dialog box with text: "The VKontakte server returned an error of type 114 in reply to method photos.save: Invalid album id" I can reproduce the crash when I try to upload more than one image at once. I'll investigate. Alexander, What's news about you investigations ? Gilles Caulier Git commit 631f6bb19c9045ab9ef0d4c1a83d6b700cf7138f by Alexander Potashev. Committed on 10/05/2015 at 22:31. Pushed by aspotashev into branch 'master'. Do not emitResult multiple times May lead to a crash if the caller is not ready for that. Also moved m_jobs.removeAll(job) closed to ends of methods to avoid the situation when m_jobs is empty but there is something left to do. M +32 -14 libkvkontakte/uploadphotosjob.cpp http://commits.kde.org/libkvkontakte/631f6bb19c9045ab9ef0d4c1a83d6b700cf7138f (In reply to fuckel from comment #2) > Yes, it is a dialog box with text: > "The VKontakte server returned an error of type 114 in reply to method > photos.save: Invalid album id" Wait a minute... I fixed only the crash when image upload fails. The original problem was in the "Invalid album id" error message. It's an error code described here: https://vk.com/pages?oid=-1&p=photos.save , but I never got this error and I don't know how you could get it. Please enable debugging output for "kipiplugins" via kdebugdialog, run digiKam in command line and tell us what album ID is being sent to the server (look for "aid" in `Vkontakte::VkontakteJob::start: Starting request KUrl("https://api.vkontakte.ru/method/photos.save?aid=xxxxxxxxx&[...]")` or whatever API method fails). Git commit 1b1a8d4b2c7a4ba8cd1fdadb11c79bfcd81029d2 by Alexander Potashev. Committed on 26/05/2015 at 09:14. Pushed by aspotashev into branch 'master'. vkontakte: Block UI during album deletion If we don't block UI before starting the album deletion job, the user may click the Delete button again and end up with two album deletion jobs for the same album. This will result in error "Invalid album id" when trying to delete the album the second time. M +1 -0 vkontakte/albumchooserwidget.cpp http://commits.kde.org/kipi-plugins/1b1a8d4b2c7a4ba8cd1fdadb11c79bfcd81029d2 Git commit 62cdaa177cc1e4d27e0dbe27e5b10cce8d99ad0c by Alexander Potashev. Committed on 26/05/2015 at 09:22. Pushed by aspotashev into branch 'frameworks'. Merge commit 1b1a8d4b2c7a4ba8cd1fdadb11c79bfcd81029d2 from master to frameworks vkontakte: Block UI during album deletion If we don't block UI before starting the album deletion job, the user may click the Delete button again and end up with two album deletion jobs for the same album. This will result in error "Invalid album id" when trying to delete the album the second time. M +1 -0 PORT.KF5/FACTORIZE/vkontakte/albumchooserwidget.cpp http://commits.kde.org/kipi-plugins/62cdaa177cc1e4d27e0dbe27e5b10cce8d99ad0c |