Bug 345323

Summary:	KRunner very slow reading Firefox places.sqlite, had to disable "Bookmarks" plugin
Product:	[Plasma] krunner	Reporter:	Vitaliy Filippov <vitalif>
Component:	bookmarks	Assignee:	Vishesh Handa <me>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	4.11.10
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:		Version Fixed In:

Description Vitaliy Filippov 2015-03-19 09:04:53 UTC

Hi!
On my machine, KRunner was very very slow - pauses after pressing Alt-F2 reached 15-20 seconds.
I've looked into krunner strace and discovered that it was reading almost whole places.sqlite of my Firefox profile.
But I have NO bookmarks in Firefox! (ZERO bookmarks) (except search engine abbreviations)
I've disabled the Bookmarks plugin of KRunner and now it's lightning fast.

So, why KRunner reads the whole places.sqlite file? I think it's the bug - it should only look for bookmarks, not for the history.

Reproducible: Always

Comment 1 Vishesh Handa 2015-03-19 13:11:00 UTC

Does KRunner actually visible pause? Each runner is typically run in its own thread. So, while it may be doing a lot of operations, it should not impact the GUI.

Comment 2 Vitaliy Filippov 2015-03-19 13:13:24 UTC

It's not only visibly paused, it's not shown at all until reading is finished.
I.e. I press Alt-F2 and nothing happens for 15-20 seconds. Krunner "window" appears only this pause.

Comment 3 Vishesh Handa 2015-03-19 13:27:09 UTC

I've looked at the code, and it is only reading the bookmarks (and places for crosschecking some stuff) part of the places sqlite. It isn't reading the history or any other part - http://people.mozilla.org/~dietrich/places-erd.png

Please let me know how big that file is for you. Either way, we should not be blocking the UI ever. Considering that *all* of the UI code has been rewritten for Plasma 5, I'm inclined to think that this bug is FIXED.

If you can reproduce this with Plasma 5, please feel free to reopen it.

Comment 4 Vitaliy Filippov 2015-03-19 13:31:34 UTC

My places.sqlite is 70M in size.
Where can I take Plasma 5 debian build?

Comment 5 Vishesh Handa 2015-03-19 13:33:09 UTC

(In reply to Vitaliy Filippov from comment #4)
> My places.sqlite is 70M in size.
> Where can I take Plasma 5 debian build?

I cannot say. Please check with your distro. Kubuntu will ship Plasma 5 by default with their next release - 15.04.