Bug 345187

Summary:	When naming unkown faces digikam only remembers typed characters and not the selected name for the next face [patch]
Product:	[Applications] digikam	Reporter:	Stephan Olbrich <stephanolbrich>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, martin.tlustos, metzpinguin, veaceslav.munteanu90
Priority:	NOR	Flags:	caulier.gilles: Backport+
Version:	4.8.0
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/66ecc35fbf912353d1af9ec4077bcb303af22a49	Version Fixed In:	4.9.0
Sentry Crash Report:
Attachments:	assignname.patch

Description Stephan Olbrich 2015-03-15 18:30:25 UTC

Digikam allows fast tagging of the same person in unkown faces by remembering the last tagged person.
Unfortunatelly this only works when the name is fully typed and not selected from the list (with arrow keys and ENTER, mouse does not work, see also here:https://bugs.kde.org/show_bug.cgi?id=334244)
When selecting from the list, digikam only remembers the typed characters and not the full name.

Reproducible: Always

Steps to Reproduce:
1. goto unknown faces
2. start typing the name of one face (do not write the full name)
3. select the correct name with arrow keys and press ENTER
4. hover with the mouse over the next face

Actual Results:  
You can now see a textbox with the characters typed in 2.


Expected Results:  
The full name as selected should be in the textbox, so that you can immediatelly confirm the name if it is the correct one.

Comment 1 Maik Qualmann 2015-03-22 20:46:45 UTC

Created attachment 91688 [details]
assignname.patch

This patch sets the full name from the list.

Maik

Comment 2 Maik Qualmann 2015-03-23 11:35:04 UTC

Git commit e920eea8f2bd123af2a0a2a65c59fc60c9f6609d by Maik Qualmann.
Committed on 23/03/2015 at 11:32.
Pushed by mqualmann into branch 'master'.

Apply patch # 91688 to set the full name in the LineEdit from the completion list.
FIXED-IN: 4.9.0

M  +3    -2    NEWS
M  +5    -0    app/tags/addtagslineedit.cpp

http://commits.kde.org/digikam/e920eea8f2bd123af2a0a2a65c59fc60c9f6609d

Comment 3 caulier.gilles 2015-03-23 13:45:24 UTC

Veaceslav,

I take a look to small Maik patch from this file to backport it on addtagslineedit.cpp from frameworks branch. With TagModelCompletion port from KCompletion  to QCompleter, i have some questions :

- port still incomplete ? I see a lots of code removed. Some signals from AddTagLineEdit are not used anymore (as taggingActionActived() for ex.).
- This patch really need to be backported to KF5 ?

Gilles

Comment 4 Veaceslav Munteanu 2015-03-23 15:10:47 UTC

I will come to look into QCompleter port after this week. Please add a label to all bugs resolved by Maik regarding addtagslineedit so I could track them faster when fixing the new implementation.

Comment 5 caulier.gilles 2015-03-23 15:19:00 UTC

Veaceslav,

I cannot create keywords in bugzilla (right missing).

I turn on "backport" property

For the moment, it's the only file to take a look in Frameworks branch about QCompleter.

Gilles

Comment 6 caulier.gilles 2015-04-04 11:38:20 UTC

Veaceslav,

QCompleter port is not yet complete in frameworks branch. Right ?

Also give in mind this entry where patch from Maik still to backport from master with adjustments to be compatible with new implementation.

Gilles

Comment 7 caulier.gilles 2015-05-08 12:19:23 UTC

Veaceslav,

From your last commit in digiKam frameworks branch, few days ago, to continue QCompleter port, did you take a care about this simple patch to backport and adjust with your new code ?

Gilles

Comment 8 Veaceslav Munteanu 2015-05-11 22:09:09 UTC

Git commit 66ecc35fbf912353d1af9ec4077bcb303af22a49 by Veaceslav Munteanu.
Committed on 11/05/2015 at 22:09.
Pushed by munteanu into branch 'frameworks'.
Related: bug 920, bug 8, bug 2, bug 123, bug 2, bug 0, bug 2, bug 65, bug 59, bug 60, bug 9, bug 6609

M  +4    -1    libs/tags/addtagslineedit.cpp

http://commits.kde.org/digikam/66ecc35fbf912353d1af9ec4077bcb303af22a49

Comment 9 Veaceslav Munteanu 2015-05-11 22:10:58 UTC

I just blindly backported the commit, still can't get over that overlay bug in assignment widget in frameworks branch..

Comment 10 caulier.gilles 2016-11-29 11:19:58 UTC

Maik,

Any reason to have this report re-opened ? The fix do not work with current implementation ?

Gilles

Comment 11 Maik Qualmann 2016-12-08 21:50:12 UTC

Tested with the current version (digiKam-5.4.0), no problem found. I close this bug.

Maik