Bug 345144

Summary: remove kdelibs4support not finished (frameworks branch)
Product: [Applications] digikam Reporter: Gustavo Alvarez <sl1pkn07>
Component: Portability-RuntimeAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: 5.0.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/cce3c63eee63d666333072c44ad487a733aa1a27 Version Fixed In: 5.0.0
Sentry Crash Report:
Attachments: a patch to solve fail build

Description Gustavo Alvarez 2015-03-14 13:46:26 UTC 
when build a latest git code from digikam (frameworks branch) projects.kde.org, fail build (in "configure" step) with this message:

CMake Error at CMakeLists.txt:313 (MACRO_BOOL_TO_01):
  Unknown CMake command "MACRO_BOOL_TO_01".


-- Configuring incomplete, errors occurred!
See also "/home/sl1pkn07/aplicaciones/digikam-frameworks-git/src/build/CMakeFiles/CMakeOutput.log".


MACRO_BOOL_TO_01 is provided by kdelibs4ssupport

to fix this message is need, if don't want add kdelibs4support to dependecies again, copy the 'MacroBoolTo01.cmake' from kdelibs4support to 'digikam/cmake/modules folde'r, and add this in main digikam CMakeLists.txt:

include(MacroBoolTo01)


but with this still fails. because in:

http://quickgit.kde.org/?p=digikam.git&a=blob&h=37d4e73ea0f2b1200c9d46fa4bffb103f244cca0&hb=896a82c1f487e14c0c4bb8e1ef4bafd23a033b00&f=showfoto%2FCMakeLists.txt#l41

and

http://quickgit.kde.org/?p=digikam.git&a=blob&h=d63afc0573a7d35e08dd2409209860b126d5e630&hb=896a82c1f487e14c0c4bb8e1ef4bafd23a033b00&f=app%2FCMakeLists.txt#l210

points to need more kdelibs4support macros

to solve this, i handle those like a this method on kruler commit:

http://quickgit.kde.org/?p=kruler.git&a=blob&h=a1be586bd589501fd9043b9bd06304593fa5a8d6&hb=b49f9869a5e8977006a37864f1d577c25f0e11af&f=CMakeLists.txt#l53

I had attach a patch to add those changes:

http://sl1pkn07.wtf/paste/view/raw/ffc60aa1

please review it

greetings


Reproducible: Always

Steps to Reproduce:
1. install "stable" kf5 frameworks
2. download digikam frameworks branch code
3. try to build

Actual Results:  
fail build

Expected Results:  
build OK
Comment 1 Gustavo Alvarez 2015-03-14 13:48:28 UTC 
Created attachment 91559 [details]
a patch to solve fail build
Comment 2 Gustavo Alvarez 2015-03-14 13:52:35 UTC 
this patch is complementary patch for this commit:

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/d754971883d1b6dc2eed9654c690d52e4d4eaf08

because fail build since this commit
Comment 3 Veaceslav Munteanu 2015-03-14 16:22:02 UTC 
Git commit cce3c63eee63d666333072c44ad487a733aa1a27 by Veaceslav Munteanu.
Committed on 14/03/2015 at 16:21.
Pushed by munteanu into branch 'frameworks'.
Related: bug 01

M  +2    -0    CMakeLists.txt
M  +2    -1    app/CMakeLists.txt
A  +20   -0    cmake/modules/MacroBoolTo01.cmake
M  +1    -1    data/icons/apps/CMakeLists.txt
M  +2    -1    showfoto/CMakeLists.txt

http://commits.kde.org/digikam/cce3c63eee63d666333072c44ad487a733aa1a27
Comment 4 caulier.gilles 2015-03-16 09:48:34 UTC 
Git commit 5ada723c8a32584ad59163c6158bceababb702a5 by Gilles Caulier.
Committed on 10/03/2015 at 14:39.
Pushed by cgilles into branch 'frameworks'.

KDE4_ADD_APP_ICON -> ecm_add_app_icon

M  +2    -1    PORT.KF5/PENDING/photolayoutseditor/CMakeLists.txt
M  +3    -1    PORT.KF5/TODO/acquireimages/CMakeLists.txt
M  +2    -1    PORT.KF5/TODO/dngconverter/plugin/CMakeLists.txt
M  +2    -1    PORT.KF5/TODO/expoblending/CMakeLists.txt
M  +2    -1    PORT.KF5/TODO/panorama/CMakeLists.txt

http://commits.kde.org/kipi-plugins/5ada723c8a32584ad59163c6158bceababb702a5