Bug 344610

Summary:	Favorite presets are reset to 10, from time to time
Product:	[Applications] krita	Reporter:	mvowada <freebox64>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	chrjs, griffinvalley, halla, sven.langkamp, tysontanx
Priority:	NOR
Version First Reported In:	2.9
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/5485cd725a656d1c9116a7ac0eb95cbf5dec845d	Version Fixed In:
Sentry Crash Report:

Description mvowada 2015-02-26 23:43:28 UTC

The amount of favorite presets is reset to 10, from time to time. 
I have not been able to find out the reason behind this behavior. 
If I'm correct the value is stored in the .kritarc file.

Qt: 4.8.6
KDE Development Platform: 4.13.3
Krita: 2.9.0 (git 737e3d3)

Reproducible: Always

Steps to Reproduce:
1. menu -> Configure Krita -> General -> Favorite presets: 30

Actual Results:  
From time to time, the amount of favorite presets is reset to 10.

Expected Results:  
Favorite presets should remain 30, untill a new user change.

Comment 1 wolthera 2015-03-08 20:11:43 UTC

I am suspecting that there's some timing issue going on with kritarc, since this bug has appeared just after UI loading became asynchronous.

Comment 2 mvowada 2015-03-14 13:00:02 UTC

*** Bug 345137 has been marked as a duplicate of this bug. ***

Comment 3 Halla Rempt 2015-05-29 09:09:14 UTC

Git commit 5485cd725a656d1c9116a7ac0eb95cbf5dec845d by Boudewijn Rempt.
Committed on 29/05/2015 at 09:06.
Pushed by rempt into branch 'calligra/2.9'.
Related: bug 10

The problem was that the old way of saving favorite presets (by
name) saved a config entry called favoritePresets. We also stored
the number of slots in a config entry called favoritePresets. If
we'd try to restore that number, chances are we'd be reading a
string with preset names instead.

It's kinda hard to interpret "Fuzzy_textured" as a number... So we'd
go back to the default of 10.

M  +2    -2    krita/ui/kis_config.cc

http://commits.kde.org/calligra/5485cd725a656d1c9116a7ac0eb95cbf5dec845d

Comment 4 Tyson Tan 2015-06-19 09:14:00 UTC

Still resetting randomly here. When it resets, it change the current tag to Favortite Presets as well. This little glitch is driving me crazy XD.

Comment 5 Tyson Tan 2015-06-19 13:23:38 UTC

This happened twice today here. One time after I rebuilt Krita, the other time after I cleared recent document list and restarted Krita. It can happen after a few Undo/Redo cycles or switching tools as well. Nothing about the presets and tags changed before/after. Does this strike something to you?

Comment 6 Tyson Tan 2015-06-19 13:30:53 UTC

Maybe I was talking about another bug here...what I encountered was:

Krita randomly resets Favorite preset tag. All presets previously removed from "Favorite Preset (default)" tag will be re-added when the reset happens. However, user added ones will be kept. If the currently in-use tag is another one, Krita will automatically switch to Favortite Preset (default) tag in the popup palette.

I could never reliably reproduce the reset, but it happens daily, very, very often. It can happen after Krita rebuit/reinstall, clear recent document list, Undo/Redo cycles...or even barely restarting the system or Krita itself. It feels very random.

Comment 7 Halla Rempt 2015-06-19 14:39:30 UTC

Hm, but that's a different thing, right? This bug was about the number of items in the favourites popup being reset. The selected tag being reset is something different, and dashed hard to track down... Do we have already a separate bug for that? I'm so behind with bug triaging...

Comment 8 Sven Langkamp 2015-06-20 08:36:23 UTC

Preset number reset and favorite preset reset would indicate that the kritarc settings are lost and it falls back to the default settings.