Bug 344492

Summary:	Multibrush mirror issues
Product:	[Applications] krita	Reporter:	Bollebib <kwadraatnope>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	animtim, dimula73, griffinvalley, osxyz
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Bollebib 2015-02-23 15:53:38 UTC

3 issues that might be related


ISSUE 1
1)Set multibrush to mirror ->horizontally
2)pick brush basic_circle
3)set size to 2 pixels (or more),to see the results more accurately   (disable opacity,flow and size dynamic for more clarity)
4)make sure SHARPNESS dynamic is OFF
5)make a stroke and compare the 2
=>they are NOT 100% correct mirrors  (zoom in really close)


Very subtle pixeldifferences can be spotted


This is true for Brush tip Mask type SOFT and DEFAULT
if you put MASK TYPE to GAUSSIAN ,this issue seems solved. So it's limited to SOFT and DEFAULT

ISSUE 2 

continue from same brush you used in ISSUE1
1)choose a predefined brush tip that has a clear difference betwen left and right side
2)paint
=>you will see that the predefined brush tip is NOT mirrored


ISSUE 3

1)choose a predefined animation brush
2)paint
=>not mirrored and not even the same stamp is used.

ask more questions here or on IRC (Bollebib) if you have trouble understanding what is meant.

because if this issue,settins like SCATTER add to the incorrectnessof the strokes



 While these issues are not huge, a mirror should be 100% a mirror,as to achieve predictable results

Comment 1 Dmitry Kazakov 2015-03-06 12:51:03 UTC

Issue 1.

Short: Please use global stroke mirror settings instead.

Long: Multibrush just makes multiple strokes without any corrections, and global mirror settings also handle internal dab mirroring to get absolutely identical results. In other words Multibrush  emulates multiple identical brushes painted together, while Mirror settings generated really mirrored results.

Comment 2 Dmitry Kazakov 2015-03-06 12:52:34 UTC

Same goes for Issues 2 and 3.

Probably, we should disable mirroring in the Multihand brush at all? Or add some clear message about it?

Comment 3 Bollebib 2015-03-08 21:57:00 UTC

while I understand why you suggest that that would be impractical and not the best solution I feel.


1)The handles for the mirror mode are handy for quick and dirty mirroring,but for precise handling I much prefer the multitool
2)The axes point also looks better because the full line is less distracting and is thinnerand thus more accurate.
3)You can't rotate the mirror mode.
4) you can stack the mirror mode and multibrush mirror mode for some cool effects,so
5)when using the multibrush it's handy to switch between mirror and symmetry for compounded effects, the axes point can be reused and does NOT need to be replaced every time.


For those reasons I would much prefer there be some kind of solution to those bugs,and NOT remove mirroring from multibrush. It would limit options.

Comment 4 wolthera 2016-02-06 17:26:15 UTC

These bugs require a full rewrite of the multibrush, so we're setting them to wishlist.

Comment 5 animtim 2016-02-06 18:04:51 UTC

Hi,
I see what Bollebib means, it's a valid feature request though not a bug.
The way multibrush mirror works is useful as it allows brushes mixing color to mix the right color on every copy of the brush, unlike the dedicated mirror mode which makes a copy of the result.

I also found this useful to make the result a bit more realistic, as in not 100% perfect symmetrical result.

So I do find it useful and consistent to have both kinds of mirroring available. I think it would be maybe better to improve simple mirroring by adding more options to it to make it on-par with multi-brush mirroring (rotation, more discrete axis...), and leave multi-brush as it currently works.
This way it would also improve the mirror available with all drawing tools (versus only multibrush).