Bug 344420

Summary:	Incomplete update of sidecar after renaming face tag
Product:	[Applications] digikam	Reporter:	abwehrhuene
Component:	Metadata-Sidecar	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	4.4.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/digikam/84e7e5d8605af8ae00a2108e40ac38524e569d82	Version Fixed In:	4.9.0
Sentry Crash Report:

Description abwehrhuene 2015-02-21 10:53:42 UTC

When a face region is renamed, the xmp-sidecar-file isn't updated properly.

The NEW name is adopted in tag-hierarchies:

MicrosoftPhoto:LastKeywordXMP
lr:hierarchicalSubject
dc:subject

The OLD remains in tag hierarchies
MP:RegionInfo
mwg-rs:Regions

Apparently the new name is adopeted, when it is the content of a tag, while the old name remains only, when it is the attribute of a tag.

Reproducible: Always

Steps to Reproduce:
1. Mark a face region, call it "demo".
2. Check sidecar file => face has been added
2. Go to tag list (left side of screen).
3. Rename tag "demo" to "demo2".
4. Check foto of step 1 => face region has been renamed correctly
5. Select menu entry Album -> Write Metadata to Images
6. Check sidecar file => both old an new tag name appear

Comment 1 caulier.gilles 2015-03-26 06:59:43 UTC

digiKam 4.7.0 for Windows is available :

http://download.kde.org/stable/digikam/digiKam-installer-4.7.0-1-win32.exe.mirrorlist

Please test and report.

Thanks in advance

Gilles Caulier

Comment 2 Maik Qualmann 2015-03-27 20:06:48 UTC

We have the following problem, while writing the metadata is searched first for the full name of a person and then after the tag name. The full name of a person can not currently be changed.

1. We use only the tag name for writing metadata.
2. If the tag name is changed and it is a person, we are also updating the full name.

I am looking for number 2.

Maik

Comment 3 Maik Qualmann 2015-03-28 19:01:03 UTC

Git commit 84e7e5d8605af8ae00a2108e40ac38524e569d82 by Maik Qualmann.
Committed on 28/03/2015 at 18:47.
Pushed by mqualmann into branch 'master'.

if a face tag is renamed, the property full name is also updated
FIXED-IN: 4.9.0

M  +3    -1    NEWS
M  +13   -1    app/tags/tagmodificationhelper.cpp

http://commits.kde.org/digikam/84e7e5d8605af8ae00a2108e40ac38524e569d82

Comment 4 caulier.gilles 2015-03-28 20:41:43 UTC

Git commit 8bcbf5d6b83eb2b92a01cf6db16d3c42f6d7889c by Gilles Caulier.
Committed on 26/03/2015 at 23:41.
Pushed by cgilles into branch 'frameworks'.

backport commit #84e7e5d8605af8ae00a2108e40ac38524e569d82 from git/master to frameworks branch

M  +13   -1    libs/tags/tagmodificationhelper.cpp

http://commits.kde.org/digikam/8bcbf5d6b83eb2b92a01cf6db16d3c42f6d7889c