Bug 344355

Summary:	Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation
Product:	[Frameworks and Libraries] kio-extras	Reporter:	Eugene Shalygin <eugene.shalygin+bugzilla.kde>
Component:	default	Assignee:	Plasma Development Mailing List <plasma-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cfeck, david.narvaez, faure, hrvoje.senjan, lbeltrame, lukas
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/kio-extras/d50a54f861f80f78d85f8fdefb6959f6c44828d3	Version Fixed In:
Sentry Crash Report:

Description Eugene Shalygin 2015-02-19 16:47:46 UTC

After the given commit generation of new thumbnails does not happen. PreviewJobPrivate::createThumbnail tries to execute thumbnail generation job, but it returns no data. Is it supposed to work with the current generators? The linked review request  does not say anything about this.

Reproducible: Always

Steps to Reproduce:
Use dolphin or previewtest test app from kio 

Actual Results:  
No thumbnails for new files in Dolphin or "Failed" message in previewtest app


Reverting this commit brings back thumbnails generation

Comment 1 Lukáš Tinkl 2015-02-19 16:53:55 UTC

Confirmed, noticed the same recently

Comment 2 Luca Beltrame 2015-02-23 22:57:59 UTC

Adding David Faure to CC, since he's the most knowledgeable on KIO. Basically all PreviewJobs will not work. David, where should one look for clues?

Comment 3 Christoph Feck 2015-02-27 17:27:05 UTC

Adding the other David.

Comment 4 Lukáš Tinkl 2015-03-02 08:39:18 UTC

Git commit d50a54f861f80f78d85f8fdefb6959f6c44828d3 by Lukáš Tinkl.
Committed on 02/03/2015 at 08:38.
Pushed by lukas into branch 'master'.

unbreak thumbnail plguin loading

M  +2    -1    thumbnail/thumbnail.cpp

http://commits.kde.org/kio-extras/d50a54f861f80f78d85f8fdefb6959f6c44828d3