Bug 344346

Summary: Artifacts in new "Fill" layers by adding large vector selections
Product: [Applications] krita Reporter: mvowada <freebox64>
Component: Layer StackAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73
Priority: NOR    
Version: 2.9 Beta   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/3bd4c3c8785d10df9b54499ea0b42a4353194c08 Version Fixed In:
Sentry Crash Report:
Attachments: Artifacts in new "Fill" layers by adding large vector selections - Video

Description mvowada 2015-02-19 12:49:38 UTC 
When I create a new "Fill" layer by adding a relatively large vector selection, the new layer has artifacts. No problems by using large regular selections. (please, see also the video in attachment in comment below)

Reproducible: Always

Steps to Reproduce:
1. Create a large regular selection
2. Menu -> Select -> Convert to Vector Selection
2. toolbox -> Add > Fill layer > Color/Pattern type (it doesn't matter)

Actual Results:  
The new "Fill" layer has artifacts by adding large vector selections. No problems with large regular selections.

Expected Results:  
"Fill" layer with large vector selections shouldn't be affected by artifacts.

(Artifacts in new "Fill" layers, seem to disappear by dragging on canvas, opaque content over them).
Comment 1 mvowada 2015-02-19 12:50:33 UTC 
Created attachment 91171 [details]
Artifacts in new "Fill" layers by adding large vector selections - Video
Comment 2 Dmitry Kazakov 2015-03-02 08:24:03 UTC 
Git commit 3bd4c3c8785d10df9b54499ea0b42a4353194c08 by Dmitry Kazakov.
Committed on 02/03/2015 at 07:20.
Pushed by dkazakov into branch 'calligra/2.9'.

Fix artifacts on Fill Layers when too many parallel updates happen

We shouldn't regenerate the portions of the selection that are not
inside current accessRect.

M  +1    -1    krita/image/generator/kis_generator_layer.cpp
M  +2    -1    krita/image/kis_selection_based_layer.cpp

http://commits.kde.org/calligra/3bd4c3c8785d10df9b54499ea0b42a4353194c08
Comment 3 mvowada 2015-03-02 09:06:15 UTC 
Thank you, problem solved. Just tested with Krita: 2.9.0 (git 3bd4c3c)
Comment 4 Dmitry Kazakov 2015-03-02 11:54:46 UTC 
You are welcome! :)