| Summary: | Rounding box drawing characters don't line up correctly. | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Parker Coates <coates> |
| Component: | font | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 2.14.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/konsole/f0628b4d5a6940ec06c26d7cae5cf13c48bfe224 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
A screenshot showing 'tig' open in both Konsole and Lilyterm using identical fonts. Also the same font open in KCharSelect.
Proof of concept patch against the KDE/4.14 branch. |
||
Created attachment 91129 [details]
A screenshot showing 'tig' open in both Konsole and Lilyterm using identical fonts. Also the same font open in KCharSelect.
Created attachment 91161 [details]
Proof of concept patch against the KDE/4.14 branch.
Thanks - I'm looking at this now Hey, Kurt. What did you think? It will likely go into the next version - I noticed a few oddities but it is better than the current state. I'd be happy to fix any concerns you might have. Would you like me to put it up on ReviewBoard so you can comment there? Git commit 1a61aaa5915b5c4a5b205e87d35c38562f932fe0 by Kurt Hindenburg. Committed on 14/03/2015 at 15:36. Pushed by hindenburg into branch 'master'. Fix rounding line characters so they line up regardless of font Unicode has 4 rounded corner characters for prettier box drawing: U+256D, U+256E, U+256F, U+2570 Konsole doesn't always render these such that they line up with the more "normal" box drawing characters. THanks to Parker Coates coates kde org for report and patch M +5 -15 src/Character.h M +83 -0 src/TerminalDisplay.cpp http://commits.kde.org/konsole/1a61aaa5915b5c4a5b205e87d35c38562f932fe0 Git commit f0628b4d5a6940ec06c26d7cae5cf13c48bfe224 by Kurt Hindenburg. Committed on 14/03/2015 at 15:36. Pushed by hindenburg into branch 'Applications/14.12'. Fix rounding line characters so they line up regardless of font Unicode has 4 rounded corner characters for prettier box drawing: U+256D, U+256E, U+256F, U+2570 Konsole doesn't always render these such that they line up with the more "normal" box drawing characters. THanks to Parker Coates coates kde org for report and patch (cherry picked from commit 1a61aaa5915b5c4a5b205e87d35c38562f932fe0) M +5 -15 src/Character.h M +83 -0 src/TerminalDisplay.cpp http://commits.kde.org/konsole/f0628b4d5a6940ec06c26d7cae5cf13c48bfe224 |
Unicode has 4 rounded corner characters for prettier box drawing: ╭ BOX DRAWINGS LIGHT ARC DOWN AND RIGHT (U+256D) ╮ BOX DRAWINGS LIGHT ARC DOWN AND LEFT (U+256E) ╯ BOX DRAWINGS LIGHT ARC UP AND LEFT (U+256F) ╰ BOX DRAWINGS LIGHT ARC UP AND RIGHT (U+2570) Unfortunately, Konsole doesn't always render these such that they line up with the more "normal" box drawing characters. See the screenshot. It seems that Konsole has some special handling for normal box drawing characters, since they properly grow to accomodate an increased line spacing and never change thickness regardless of the font size. So my guess is that these rounded characters aren't receiving that same special treatment. Reproducible: Always Steps to Reproduce: 1. Switch console to a font that supports these characters. (Deja Vu Sans Mono is an excellent choice.) 2. a) Run the following command: echo -e '╭─┴─╮\n│ ☠ │\n╰─┬─╯' b) Alternatively, run "tig" inside a git repository and press '~' to switch to fancy line drawing. 3. Use Ctrl+Mousewheel to play with the font size and watch for misalignments. Actual Results: The rounded characters are drawn differently than the square ones and don't line up properly.