Bug 344243

Summary:	Edit Brush Settings window always opens downward despite Toolbar position
Product:	[Applications] krita	Reporter:	Ula <kayoragreen>
Component:	General	Assignee:	Halla Rempt <halla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, jdrageme01, kaerhon
Priority:	NOR
Version First Reported In:	2.9 Beta
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
URL:	http://fc02.deviantart.net/fs71/f/2015/047/4/5/krita_bug_by_nivailis-d8i8v55.jpg
Latest Commit:	http://commits.kde.org/calligra/54f13b21870b7da5d36c47e726714fa28c8c19f5	Version Fixed In:
Sentry Crash Report:
Attachments:	krita screenshot

Description Ula 2015-02-16 14:58:37 UTC

When Brushes and Stuff Toolbar is located at the bottom of the workspace, Edit Brush Settings window still opens downward thus it's impossible to make any use of it.
Chose Brush Preset window, also from Painter's Tools, works fine, opening to the top.

Reproducible: Always

Steps to Reproduce:
1. move Brushes and Stuff Toolbar to the bottom of the workspace
2. click Edit Brush Settings icon on the Brushes and Stuff Toolbar
3.

Actual Results:  
window pops up below the icon, in the area to which user have no access

Expected Results:  
location of window should adjust to the Toolbar placement and pop up above the icon

Comment 1 Halla Rempt 2015-02-18 15:21:14 UTC

Hi Ula,

Thanks for your report. I can confirm the issue -- it should be fairly easy to fix, since the other popups seem to be fine.

Comment 2 Halla Rempt 2015-02-20 10:56:50 UTC

Git commit 3bca0935e1b1bd2260c78c96a6ee463934dc203a by Boudewijn Rempt.
Committed on 20/02/2015 at 10:54.
Pushed by rempt into branch 'calligra/2.9'.

No idea which can of worms this opens, this special-case code has a quite
weird history.

M  +1    -7    krita/ui/widgets/kis_popup_button.cc

http://commits.kde.org/calligra/3bca0935e1b1bd2260c78c96a6ee463934dc203a

Comment 3 Halla Rempt 2015-02-26 17:23:33 UTC

And now it pops up upwards if the screen is too small, it seems.

Comment 4 kaerhon 2015-02-26 17:37:58 UTC

Created attachment 91304 [details]
krita screenshot

on the top, there's the toolbar at the top of the screen, brush settings popup opens upward, and out of the screen (we see the bottom of it)

on the bottom, there's the toolbar at the bottom, and the brush-settings popup still gets out of the screen a bit, due to low resolution

Comment 5 kaerhon 2015-02-26 17:40:34 UTC

same problem here, except the brush settings window opens upward in any case.

krita is 2.9 stable,
OS is windows 7 home basic (with aero effects disabled)

Screen resolution is 1366x768

Comment 6 Halla Rempt 2015-02-27 09:17:21 UTC

Git commit 54f13b21870b7da5d36c47e726714fa28c8c19f5 by Boudewijn Rempt.
Committed on 27/02/2015 at 09:16.
Pushed by rempt into branch 'calligra/2.9'.

But on a 1024x768 screen, you'd be best off using predefined presets...

M  +3    -1    krita/ui/widgets/kis_popup_button.cc

http://commits.kde.org/calligra/54f13b21870b7da5d36c47e726714fa28c8c19f5

Comment 7 mvowada 2015-03-11 19:01:34 UTC

*** Bug 344988 has been marked as a duplicate of this bug. ***