Bug 344162

Summary:	kwallet can't open with 75c4a32c commit
Product:	[Frameworks and Libraries] frameworks-kwallet	Reporter:	desaparecido <luis.davila.pc>
Component:	general	Assignee:	Kevin Funk <kfunk>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hrvoje.senjan, kdelibs-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/kwallet-framework/45d42e1383a39aca7f66c5c60fde1559f477bb72	Version Fixed In:
Sentry Crash Report:

Description desaparecido 2015-02-14 15:04:23 UTC

Using the latest commit of kwallet I can't open it, but downgraded to 8f42f94 (was the latest commit that I builded before the bug) commit all works fine again

Reproducible: Always

Steps to Reproduce:
1. rebuild kwallet from git again and kwalletmanager to latest commit and install it
2. reboot PC and start plasma5 (git) session and not access to kwallet
3. downgrade kwallet
4. reboot PC and start plasma session and access fine to kwallet

Actual Results:  
using the latest commit each time I have the same problem, I can't access my kwallet, but if I downgrade all works fine.  

Expected Results:  
access kwallet after write my password

I use Archlinux x86-64 with [testing] repo enable, linux kernel 3.19, I use KF5 and plasma5 (and all another kde frameworks ports) from git

Comment 1 Valentin Rusu 2015-02-15 11:01:31 UTC

@kevin : seems to me that the regression was introduced by one of your two commits. Perhaps the commit 17759fc93 introduced the regression? Can you check that please?

Comment 2 Kevin Funk 2015-02-15 17:23:11 UTC

Git commit 0a23b9331a1262cf79157ba164f31fd5db0ce0a2 by Kevin Funk.
Committed on 15/02/2015 at 17:22.
Pushed by kfunk into branch 'master'.

Revert "Fix warnings"

Was a bit too eager fixing this warning, sorry. It probably changed
behavior. Someone with a better understanding of this code should check.

This reverts commit 17759fc939f3fce09dfaab0ca93fb2359eb66168.

M  +0    -2    src/runtime/kwalletd/backend/sha1.cc

http://commits.kde.org/kwallet-framework/0a23b9331a1262cf79157ba164f31fd5db0ce0a2

Comment 3 Kevin Funk 2015-02-15 17:23:35 UTC

@Reporter: Can you please check if latest Git now works for you again?

Comment 4 desaparecido 2015-02-15 18:25:50 UTC

(In reply to Kevin Funk from comment #3)
> @Reporter: Can you please check if latest Git now works for you again?

hi, I build the latest commit (0a23b93) and the problem is still there :( .. I tested many times and the is the same thing like the description, I need to downgrade to access my kwallet.

Comment 5 Kevin Funk 2015-02-15 18:43:40 UTC

@Reporter, please try to revert 75c4a32c90eac0482227b3182dbbb3de3437de82 and try again.

I can see that this commit could have also changed behavior of blowfish.cc. I've added 'qglobal.h' to blowfish.h, which then fixed the warnings in the implementation file.

src/runtime/kwalletd/backend/blowfish.cc
134:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
153:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
158:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
177:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
182:#if Q_BYTE_ORDER == Q_BIG_ENDIAN

Comment 6 desaparecido 2015-02-15 21:23:53 UTC

(In reply to Kevin Funk from comment #5)
> @Reporter, please try to revert 75c4a32c90eac0482227b3182dbbb3de3437de82 and
> try again.
> 
> I can see that this commit could have also changed behavior of blowfish.cc.
> I've added 'qglobal.h' to blowfish.h, which then fixed the warnings in the
> implementation file.
> 
> src/runtime/kwalletd/backend/blowfish.cc
> 134:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
> 153:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
> 158:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
> 177:#if Q_BYTE_ORDER == Q_BIG_ENDIAN
> 182:#if Q_BYTE_ORDER == Q_BIG_ENDIAN

re-installing 75c4a32c commit i still haven't access to my kwallet :| , so I'd downgrade to same commit working (8f42f94)

Comment 7 Hrvoje Senjan 2015-02-16 19:33:52 UTC

reverting 75c4a32c90eac0482227b3182dbbb3de3437de82 makes things work here. except that for !main wallets bug 343718 kicks in

Comment 8 Kevin Funk 2015-02-17 07:56:52 UTC

Git commit 45d42e1383a39aca7f66c5c60fde1559f477bb72 by Kevin Funk.
Committed on 17/02/2015 at 07:55.
Pushed by kfunk into branch 'master'.

Revert "Use Q_DECL_OVERRIDE where possible"

Someone with a deeper knowledge of this code should double-check each
use of Q_BYTE_ORDER and friends

This reverts commit 75c4a32c90eac0482227b3182dbbb3de3437de82.

M  +4    -4    src/runtime/kwalletd/backend/backendpersisthandler.h
M  +6    -8    src/runtime/kwalletd/backend/blowfish.h
M  +6    -8    src/runtime/kwalletd/backend/cbc.h
M  +2    -2    src/runtime/kwalletd/kbetterthankdialog.h
M  +3    -3    src/runtime/kwalletd/knewwalletdialog.h
M  +1    -1    src/runtime/kwalletd/ktimeout.h
M  +3    -3    src/runtime/kwalletd/kwalletwizard.cpp
M  +1    -1    src/runtime/kwalletd/kwalletwizard.h
M  +3    -3    src/runtime/kwalletd/migrationwizard.cpp

http://commits.kde.org/kwallet-framework/45d42e1383a39aca7f66c5c60fde1559f477bb72

Comment 9 desaparecido 2015-02-18 01:13:33 UTC

(In reply to Kevin Funk from comment #8)
> Git commit 45d42e1383a39aca7f66c5c60fde1559f477bb72 by Kevin Funk.
> Committed on 17/02/2015 at 07:55.
> Pushed by kfunk into branch 'master'.
> 
> Revert "Use Q_DECL_OVERRIDE where possible"
> 
> Someone with a deeper knowledge of this code should double-check each
> use of Q_BYTE_ORDER and friends
> 
> This reverts commit 75c4a32c90eac0482227b3182dbbb3de3437de82.
> 
> M  +4    -4    src/runtime/kwalletd/backend/backendpersisthandler.h
> M  +6    -8    src/runtime/kwalletd/backend/blowfish.h
> M  +6    -8    src/runtime/kwalletd/backend/cbc.h
> M  +2    -2    src/runtime/kwalletd/kbetterthankdialog.h
> M  +3    -3    src/runtime/kwalletd/knewwalletdialog.h
> M  +1    -1    src/runtime/kwalletd/ktimeout.h
> M  +3    -3    src/runtime/kwalletd/kwalletwizard.cpp
> M  +1    -1    src/runtime/kwalletd/kwalletwizard.h
> M  +3    -3    src/runtime/kwalletd/migrationwizard.cpp
> 
> http://commits.kde.org/kwallet-framework/
> 45d42e1383a39aca7f66c5c60fde1559f477bb72

hi, now, with this commit all works fine again :) ... so, thanks for yours work in kde community ..