Bug 343993

Summary:	Ask the user when importing an image as layer with a different colorspace than the current image.
Product:	[Applications] krita	Reporter:	Paul Geraskin <paulgeraskin>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/4edeb0dba8268bd7ce67bb5453c28ec42f89599e	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	copy from dropbox

Description Paul Geraskin 2015-02-10 09:20:27 UTC

Hi.

Every time when i import into my psd file a new image - i get different color spaces. It's a big pain.
Here is the issue after Drag'n'Drop - http://i.imgur.com/5QZfJOe.png

1)  "Image->Convert Image Color Space" does not convert all layers. Possibly it's broken. Only " Layer->Convert Layer Color Space" works.

2) Is it possible to convert all imported images (Drag'n'Drop) automatically? It's a big paint to convert new imported layers every time. PS and Gimp does it automatically.

Here is my psd and new imported layer https://dl.dropboxusercontent.com/u/26887202/Krita/base_1.zip

Comment 1 Halla Rempt 2015-02-10 09:22:05 UTC

Automatically converting dropped/imported layers to the image color space is not a good idea. There are plenty of excellent reasons for allowing mixing e.g. gray and rgb layers in the same image. We can't help it that the psd format is too stupid to allow that! Asking the user on importing an image as a layer is something we could do, though.

Comment 2 Halla Rempt 2015-02-10 09:26:14 UTC

We should also not automatically convert on export, because that will change the colors of the final image, which if it happens without explicit action from the user, is a bug.

Comment 3 Halla Rempt 2015-02-10 09:28:45 UTC

Created attachment 91003 [details]
copy from dropbox

Comment 4 Paul Geraskin 2015-02-10 09:31:01 UTC

i just paste from irc.

<mifth> boud: is it possible to make popup to "convert or not" when we drag'n'drop?
<boud> yes, but not for 2.9
<mifth> ok, good

Comment 5 Paul Geraskin 2015-02-10 10:08:24 UTC

Here is i show the issue "1)" http://youtu.be/-AjupJQNh64

Comment 6 Halla Rempt 2015-02-13 14:22:38 UTC

Git commit 88d9531486669cd71fbd487403f597e5b881a4d5 by Boudewijn Rempt.
Committed on 13/02/2015 at 14:21.
Pushed by rempt into branch 'calligra/2.9'.

We used to check whether the image colorspace and the destination
colorspace were the same, and if they were, didn't do anything. But we
should check for all layers in the stack if they are the destination
colorspace, and convert those that aren't.

Note: we might have to add a checkbox for this later, because some users
might need the old behaviour. That will have to wait until after 2.9,
though.

M  +3    -0    krita/image/kis_colorspace_convert_visitor.cpp
M  +0    -1    krita/image/kis_image.cc
M  +1    -1    krita/plugins/extensions/colorspaceconversion/dlg_colorspaceconversion.h

http://commits.kde.org/calligra/88d9531486669cd71fbd487403f597e5b881a4d5

Comment 7 Halla Rempt 2016-03-20 09:28:05 UTC

Git commit 4edeb0dba8268bd7ce67bb5453c28ec42f89599e by Boudewijn Rempt.
Committed on 20/03/2016 at 09:05.
Pushed by rempt into branch 'master'.

Since this is a workflow thing, it's an option in settings, not something
to ask the user every time. Now, if this option is checked, on importing
images as layers, they will be converted to the image colorspace. It's
off by default to preserve existing behavior.

M  +8    -0    libs/ui/dialogs/kis_dlg_preferences.cc
M  +1    -0    libs/ui/dialogs/kis_dlg_preferences.h
M  +72   -113  libs/ui/forms/wdggeneralsettings.ui
M  +11   -1    libs/ui/kis_config.cc
M  +5    -2    libs/ui/kis_config.h
M  +17   -8    libs/ui/kis_import_catcher.cc

http://commits.kde.org/krita/4edeb0dba8268bd7ce67bb5453c28ec42f89599e