Bug 343851

Summary: build failed due to "call to member function 'readLine' is ambiguous"
Product: [Applications] konsole Reporter: Takahiro Hashimoto <kenya888>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 3.90.900   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/konsole/be2b2b4b2e7d6375c852262fb1798f272697a240 Version Fixed In:
Sentry Crash Report:
Attachments: build error log
patch

Description Takahiro Hashimoto 2015-02-06 05:23:25 UTC 
Created attachment 90937 [details]
build error log

*Environment:
 - Gentoo kernel 3.17.8-gentoo-r1
 - Clang 3.5.0-r100
 - Qt5 dev branch from git source (not portage tree)

*How to reproduce:
 - Build konsole with qt5 dev branch ( with ./kdesrc-build --refresh-build konsole)

*Behavior to expected:
 - Build succeeded

*Behavior in fact:
 - Build failed with error " ProcessInfo.cpp:448:37: error: call to member function 'readLine' is ambiguous "

*Route cause:
 - As QtTextStream::readLine() has been overloaded in Qt5 dev branch[1] readLine(0) is detected as ambiguous.

*Suggestion to fix:
 - call readLine() without no arg to be set maxlen=0 as default. (see attached file)

[1] https://codereview.qt-project.org/#/c/98606/
Comment 1 Takahiro Hashimoto 2015-02-06 05:24:16 UTC 
Created attachment 90938 [details]
patch
Comment 2 Takahiro Hashimoto 2015-02-06 05:29:41 UTC 
> *Route cause:
>  - As QtTextStream::readLine() has been overloaded in Qt5 dev branch[1]
> readLine(0) is detected as ambiguous.
> [1] https://codereview.qt-project.org/#/c/98606/

sorry for typo.

*Root cause:
 - As QTextStream::readLine() has been overloaded in Qt5 dev branch[1]
readLine(0) is detected as ambiguous.
Comment 3 Kurt Hindenburg 2015-02-07 19:38:16 UTC 
Git commit be2b2b4b2e7d6375c852262fb1798f272697a240 by Kurt Hindenburg.
Committed on 07/02/2015 at 19:35.
Pushed by hindenburg into branch 'master'.

call readLine() without arg to be set maxlen=0 as default

Qt dev overloads readline()

call to member function 'readLine' is ambiguous

Thanks to Takahiro Hashimoto for report and fix

M  +1    -1    src/ProcessInfo.cpp

http://commits.kde.org/konsole/be2b2b4b2e7d6375c852262fb1798f272697a240