Bug 343722

Summary: Crop tool automatically selects an area at initiation, after changing the ratio number in Tool options
Product: [Applications] krita Reporter: Tyson Tan <tysontanx>
Component: Tools/TransformAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73, freebox64, halla
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/c696bf4ca05bc41a78223331f0125f40e55fc426 Version Fixed In:
Sentry Crash Report:
Attachments: Krita crop tool auto-selects certain area on initiation.
The problem is still present, please, see the video in attachment. (Let's reopen this report, strangely, it seems we are not allowed to reopen it. Thanks) - Krita: 2.9.0 (git bc0a3ce)

Description Tyson Tan 2015-02-03 03:05:30 UTC 
Normally, every time I initiate Crop tool, I can drag freely to create an area to crop. However, after using only Ratio field to finish a crop, every time I initiate Crop tool, a certain area was selected automatically, which is confusing and inconvenient. Once happened, it stays. Nothing I did would change the auto-loaded, memorized area-to-crop during Crop tool's initiation.

When it happens, even when the memorized area-to-crop is larger than the current canvas, Krita would still select it with Grow not checked.

This bug resets when kritarc is deleted.

Reproducible: Always

Steps to Reproduce:
0. Giving the current Krita installation is not affected by this bug yet;
1. Crop tool >> Tool options >> Ratio >> Click up/down on the right >> The whole canvas gets selected;
2. Ratio set to 3 >> Make sure Grow is unchecked >> Confirm crop;
3. Restart Krita;
4. Create a smaller, vertical picture;
5. Crop tool.

Actual Results:  
As soon as you click Crop tool's icon, an area used by Step 1 is already selected. In this case, the area-to-crop would go outside the canvas with Grow is actually unchecked.

Expected Results:  
Everytime I restarted Krita and use Crop tool, it does not remember or automatically select any previous area, so I can drag it freely myself.
Comment 1 Tyson Tan 2015-02-03 03:07:41 UTC 
>> Nothing I did would change the auto-loaded, memorized area-to-crop during Crop tool's initiation. 

I can actually change the area by using the same trick that triggers this bug.
Comment 2 Tyson Tan 2015-02-03 07:24:48 UTC 
Additional information: Things return to normal after I use crop tool for once in every session, but it would happen again in every new session.
Comment 3 Dmitry Kazakov 2015-02-18 07:58:50 UTC 
Hi, Tyson!

It looks like the bug is fixed already. Now the crop tool doesn't activate the region on activation so the inconvenience doesn't happen.

I will mark this bug as fixed. If you still think it is actual, please add a comment and reopen it :)
Comment 4 Tyson Tan 2015-02-18 13:59:35 UTC 
It doesn't seem to fix for me, though. I will report later with a clean build and more research.
Comment 5 Tyson Tan 2015-02-21 09:01:58 UTC 
Created attachment 91197 [details]
Krita crop tool auto-selects certain area on initiation.

I rebuilt and cleared the settings. The bug is still there. 

For some reason I cannot change the status to "REOPENED".

I've narrowed down the bug trigger -- the "ratio" number.

Steps to reproduce:
0. Delete kritarc;
1. New document (default 1600x1200);
2. Crop tool;
3. Tool options;
4. Ratio = 0.7 (it's already weird because the visible cropping area is actually a square, ratio=1);
5. NO need to check the "keep ratio" checkbox;
5. NO need to confirm cropping, just hit ESC to cancel;
6. Exit Krita;
7. Restart Krita, New codument (1600x1200);
8. Crop tool;
9. A ratio=0.7 area is already selected, and it is growing out of the current canvas.
Comment 6 mvowada 2015-03-02 08:47:58 UTC 
Created attachment 91370 [details]
The problem is still present, please, see the video in attachment. (Let's reopen this report, strangely, it seems we are not allowed to reopen it. Thanks) - Krita: 2.9.0 (git bc0a3ce)
Comment 7 Halla Rempt 2015-04-21 17:54:41 UTC 
Git commit c696bf4ca05bc41a78223331f0125f40e55fc426 by Boudewijn Rempt.
Committed on 21/04/2015 at 17:54.
Pushed by rempt into branch 'calligra/2.9'.

These shouldn't be persistent because from one image to another, they
don't make sense

M  +0    -4    krita/plugins/tools/tool_crop/kis_tool_crop.cc

http://commits.kde.org/calligra/c696bf4ca05bc41a78223331f0125f40e55fc426
Comment 8 Tyson Tan 2015-04-22 01:04:58 UTC 
Thank you for fixing this bug! :D