Bug 343719

Summary:	Crash on close with a line vector in a Group layer, and the outer end set to the 8th marker from bottom
Product:	[Applications] krita	Reporter:	mvowada <freebox64>
Component:	Layers/Vector	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	griffinvalley, halla
Priority:	NOR
Version:	2.9 Beta
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/e3b2d7e4049e4b27c6643e3d4b32a04247518123	Version Fixed In:
Sentry Crash Report:
Attachments:	Crash on close with a line vector in a Group layer, and the outer end set to the 8th marker from bottom - BACKTRACE Crash on close with a line vector in a Group layer, and the outer end set to the 8th marker from bottom - VIDEO

Description mvowada 2015-02-03 01:43:24 UTC

I get a crash:
1. by closing a document 
2. with a line layed down on a "Vector layer" which is nested inside a "Group layer"
3. the line having the outer end, marked with the eighth arrowhead starting from the bottom of the drop-down menu of markers

Ubuntu 14.04 Unity - Krita 2.9 Beta 2 (git 9715bb5)

Reproducible: Always

Steps to Reproduce:
1. create a vector layer inside a group layer
2. create a line with the Line Tool
3. select the line
4. Tool Options panel > Line > and set the outer end of the line with the eighth arrowhead marker, starting from the bottom of the drop-down menu.

Actual Results:  
Krita crash on close

Comment 1 mvowada 2015-02-03 01:44:23 UTC

Created attachment 90883 [details]
Crash on close with a line vector in a Group layer, and the outer end set to the 8th marker from bottom - BACKTRACE

Comment 2 Halla Rempt 2015-02-03 08:03:57 UTC

Judging from the backtrace, I think this is exactly the same bug as https://bugs.kde.org/show_bug.cgi?id=343515, but this report makes it easier to to reproduce :-)

Comment 3 Halla Rempt 2015-02-03 08:04:12 UTC

*** Bug 343515 has been marked as a duplicate of this bug. ***

Comment 4 Halla Rempt 2015-02-03 18:30:18 UTC

Meh... I still cannot reproduce.

Comment 5 mvowada 2015-02-03 21:17:45 UTC

Thank you. Here after updating to krita 2.9 Beta 2 (git 066c942), I'm still able to reproduce the problem. I'm wondering if it's something related to my system... :| I'm on Ubuntu 14.04 Unity

Comment 6 mvowada 2015-02-03 21:19:43 UTC

Created attachment 90892 [details]
Crash on close with a line vector in a Group layer, and the outer end set to the 8th marker from bottom - VIDEO

Comment 7 Halla Rempt 2015-02-03 21:20:22 UTC

No... The backtrace is pretty clear: it _is_ a problem in the memory management of marker objects. I'm just to dumb to reproduce it, let alone fix it. What is happening is that the marker get deleted twice, I'm pretty sure of that.

Comment 8 mvowada 2015-02-03 21:40:58 UTC

No problem :) Thank you!

Comment 9 Sven Langkamp 2015-02-21 14:19:54 UTC

Git commit e3b2d7e4049e4b27c6643e3d4b32a04247518123 by Sven Langkamp.
Committed on 21/02/2015 at 14:18.
Pushed by langkamp into branch 'calligra/2.9'.

Use shared pointers for markers
REVIEW:122584

M  +2    -1    libs/flake/KoMarker.h
M  +12   -9    libs/flake/KoMarkerCollection.cpp
M  +1    -1    libs/flake/KoMarkerCollection.h
M  +4    -4    libs/flake/KoMarkerData.cpp

http://commits.kde.org/calligra/e3b2d7e4049e4b27c6643e3d4b32a04247518123