| Summary: | Tag Manager crashes when adding a new tag | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | vato <vato12003> |
| Component: | Tags-Manager | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | caulier.gilles, metzpinguin, veaceslav.munteanu90, wbauer1 |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 4.6.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| See Also: | http://bugzilla.opensuse.org/show_bug.cgi?id=940857 | ||
| Latest Commit: | http://commits.kde.org/digikam/23adeac16184bde826d1287af3bbea8819f4e4ec | Version Fixed In: | 4.13.0 |
| Sentry Crash Report: | |||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
vato
2015-01-29 22:57:18 UTC
It crash in Qt::QString API when TagEditDialog is started to change tag properties, especially the icon. The QString instance content is the path of tag icon on your system. Gilles Caulier After upgrading to the newest build in the repositories, Digikam does not crash anymore. Created attachment 93920 [details]
New crash information added by DrKonqi
digikam (4.11.0) on KDE Platform 4.14.9 using Qt 4.8.6
- What I was doing when the application crashed:
Open the tag editor, select the existing "Persons" tag and click on "+" to create a new sub-tag.
Then delete the sub-tag again.
If you click on '+' again, digikam crahes.
Or just delete the existing "Persons" tag, digikam will crash if you click on'+' to create a new one afterwards.
This is reproducible with both digikam 4.11.0 and the latest git version in the frameworks5 branch.
-- Backtrace (Reduced):
#5 0x000000000059d200 in Digikam::TAlbum::icon() const (other=..., this=0x7ffc1af1cd40, this@entry=0x7ffc1af1ca50) at /usr/include/QtCore/qstring.h:725
#6 0x000000000059d200 in Digikam::TAlbum::icon() const (this=this@entry=0x0) at /usr/src/debug/digikam-4.11.0/core/app/album/album.cpp:526
#7 0x000000000064297b in Digikam::TagEditDlg::TagEditDlg(QWidget*, Digikam::TAlbum*, bool) (this=0x3ba0670, parent=<optimized out>, album=0x0, create=<optimized out>) at /usr/src/debug/digikam-4.11.0/core/app/tags/tageditdlg.cpp:182
#8 0x00000000006438cd in Digikam::TagEditDlg::tagCreate(QWidget*, Digikam::TAlbum*, QString&, QString&, QKeySequence&) (parent=0x6583390, album=album@entry=0x0, title=..., icon=..., ks=...) at /usr/src/debug/digikam-4.11.0/core/app/tags/tageditdlg.cpp:346
#9 0x0000000000648a1a in Digikam::TagsManager::slotAddAction() (this=<optimized out>) at /usr/src/debug/digikam-4.11.0/core/app/tags/tagsmanager/tagsmanager.cpp:265
Reopening per the previous comment. Git commit 23adeac16184bde826d1287af3bbea8819f4e4ec by Maik Qualmann. Committed on 06/08/2015 at 18:48. Pushed by mqualmann into branch 'master'. disable the add tag action when no tag is selected FIXED-IN: 4.13.0 M +2 -1 NEWS M +2 -0 app/tags/tagsmanager/tagsmanager.cpp http://commits.kde.org/digikam/23adeac16184bde826d1287af3bbea8819f4e4ec Haha .. commit collision :D Maik, revert your commit, this is not the intended bahaviour :)) I commited a fixin frameworks branch Yes, check on whether the parent zero's what I thought. But the add action button should be turned off. I will add your patch of frameworks also to master? Maik I will revert your commit and port mine, since default intended behaviour is to add tags under root tag, if nothing is selected. Add tag must be always enabled. Yes, I have now seen that the root tag is then taken. Ok, make my commit please undo. Maik done... Wolfgang, please check if crash is fixed Wow, thanks for that quick fix! :-) (In reply to Veaceslav Munteanu from comment #10) > done... Wolfgang, please check if crash is fixed I will. I suppose I need commits 6eace13 and 445a9f3 for the KDE4 version, right? Just use the current git master branch or frameworks branch(where is also 959b42e for KDE4, which reverts Maik's commit). Both have now the same fix. I tried bot the latest git master branch and frameworks now, and cannot reproduce the crash in either. So this seems to be fixed indeed, thanks again! |