| Summary: | empty notification string on wall messages | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | rapar |
| Component: | Notifications | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | mklapetek |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| URL: | http://www.youtube.com/watch?v=9W_2cPsybnw | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/2aecaa502c9ae312069c74a7c86ce9163e4a6d51 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
rapar
2015-01-29 16:51:43 UTC
wall doesn't do anything at all here, do I need to enable something somewhere? Well it's a common tool for sending messages to all terminals across the system. In my distribution, this binary is in util-linux. It's similar to "talk". I do have wall present, it just doesn't do anything at all. If you open a terminal that registers a pts/X or go to a tty, typing "wall <message>" should send a message to every tty/pts which the same user observes. The root user can send messages to all the users. Ok, this needs kpty build with utempter (is not in cmake output), then it will work across konsoles and stuff. One thing that's immediately obvious is that the message starts with empty line, so that needs to be trimmed. However I'm not sure this will fit into the popup anyway, it's limited to 3 lines I think and two lines are just the "Broadcast message from blah blah". I'll see what I can do. There we go: https://git.reviewboard.kde.org/r/122314/ Git commit 2aecaa502c9ae312069c74a7c86ce9163e4a6d51 by Martin Klapetek. Committed on 05/02/2015 at 10:15. Pushed by mklapetek into branch 'Plasma/5.2'. Sanitize whitespace in notification popups With this patch the text is first trimmed from whitespace at the beginning and end, then all \ns are converted to <br/> (as before), then the text replaces all remaining inner whitespace with single space and finally, if there are two or more new lines in succession, it turns it into just one. REVIEW: 122314 M +9 -0 dataengines/notifications/notificationsengine.cpp http://commits.kde.org/plasma-workspace/2aecaa502c9ae312069c74a7c86ce9163e4a6d51 Good job! :) |