| Summary: | Does not sort numbers naturally any longer | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Chris Warrick <kwpolska> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | abderrahman.najjar, accounts+bugs.kde, ant.cervone, bugskdeorg, ct.gsk, default_357-line, eric.brunet, faure, greg, kde-2011.08, kde, kdelibs-bugs, konstantinos.smanis, leszek.lesner, lueck, myriam, nate, public+kde, roten.ben, sfromley, simonandric5, superori, terranair |
| Priority: | NOR | ||
| Version: | 5.24.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kio/f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8 | Version Fixed In: | 5.34 |
| Sentry Crash Report: | |||
| Attachments: |
Dolphin (KDE 4) vs Gwenview (KDE 5).
Enable natural sorting on the QCollator for KDirSortFilterProxyModel |
||
|
Description
Chris Warrick
2015-01-28 12:16:12 UTC
Created attachment 90745 [details]
Dolphin (KDE 4) vs Gwenview (KDE 5).
Confirm that this is still occurring on Gwenview 5.0.0pre. Gwenview still doesn't respect the "Natural sorting of items" setting in Dolphin. dpkg -l gwenview* | grep ^ii ii gwenview 4:15.04.1-0ubuntu1~ubuntu15.04~ppa1 amd64 image viewer Thanks This bug is in the latest stable pacman -Qs gwenview local/gwenview 15.04.3-1 pacman -Qs plasma-desktop local/plasma-desktop 5.3.2-2 Confirmed in 15.08 in a up-to-date fedora 23 installation. Also in Kubuntu 16.04 gwenview 15.12.3 Confirmed in in Kubuntu 16.04 (gwenview 15.12.3) Still occurs, very annoying. Confirm on gwenview 15.12.3, qt 5.7, kf5.24.0. This is really annoying. *** This bug has been confirmed by popular vote. *** Created attachment 100413 [details]
Enable natural sorting on the QCollator for KDirSortFilterProxyModel
Turns out this is actually a bug in KIO. QCollator does not enable "numeric mode", which KDirSortFilterProxyModel advertises as enabled, by default, and KIO's KDirSortFilterProxyModel does not enable it at all. As a result, as far as I can tell, natural sort never worked in KF5/Qt5.
Patch for KIO is attached.
(In reply to FeepingCreature from comment #11) > Created attachment 100413 [details] > Enable natural sorting on the QCollator for KDirSortFilterProxyModel > > Turns out this is actually a bug in KIO. QCollator does not enable "numeric > mode", which KDirSortFilterProxyModel advertises as enabled, by default, and > KIO's KDirSortFilterProxyModel does not enable it at all. As a result, as > far as I can tell, natural sort never worked in KF5/Qt5. > > Patch for KIO is attached. Please upload your patch to https://git.reviewboard.kde.org (repository kio) and add group kdeframewotks as reviewers Thanks Was already uploaded there. See https://git.reviewboard.kde.org/r/128574/ *** Bug 349390 has been marked as a duplicate of this bug. *** This bug managed to annoy the hell out of that itching part of my brain, so I did a little digging. I posted my review on https://git.reviewboard.kde.org/r/128574/ Konstantinos Smanis's patch got downstreamed into openSUSE's Plasma repo, and I can confirm that it works and resolves the issue. Can we get it moved alone here so Plasma users in other distros can benefit as well? Er, FeepingCreature's patch. I know it's not perfect, but it does resolve the issue, and we can integrate the perfect fix afterwards, right? Git commit f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8 by Elvis Angelaccio, on behalf of Mathis Beer. Committed on 28/04/2017 at 15:21. Pushed by elvisangelaccio into branch 'master'. KDirSortFilterProxyModel: bring back natural sorting This fixes a regression of the KF5 port. FIXED-IN: 5.34 REVIEW: 128574 M +1 -0 src/filewidgets/kdirsortfilterproxymodel.cpp https://commits.kde.org/kio/f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8 *** Bug 236059 has been marked as a duplicate of this bug. *** |