Summary: | Coloring no longer works for svg elements with the hint-apply-color-scheme flag | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Mircea Kitsune <sonichedgehog_hyperblast00> |
Component: | general | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bhush94, sonichedgehog_hyperblast00 |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | 1.0 | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/plasma-framework/534733558c76572a191b21ebe065d335843e2855 | Version Fixed In: |
Description
Mircea Kitsune
2015-01-27 19:18:39 UTC
I just tested to see if colored elements work for KWin themes (Aurorae), using the theme Air Oxygen Color: http://opendesktop.org/content/show.php?content=136510 Apparently they do: The buttons in this theme change color based on the color scheme, so the issue might only happen for plasmashell. It is however difficult to tell, because changing color schemes is broken in general: Sometimes the changes are completely ignored, while at other times they're only applied to new windows or take place on just certain elements. Even after I restart the computer and log back in, some colors in the new scheme are not applied yet! This might or might not be the same problem, but there are clearly many issues with color schemes in Framework 5. Git commit bdda85a40deef288b7e8c82212f9c9b50a4ee0aa by Marco Martin. Committed on 28/01/2015 at 13:45. Pushed by gerrit into branch 'master'. restore hint-apply-color-scheme support make hint-apply-color-scheme work (kiconeffect based coloring), and make sure the kcolorschemes are reloaded when app palette changes and the theme follows system colors Change-Id: I0a7a7eb0f89ed0948e618f1d608521f235aa1959 M +1 -0 src/plasma/CMakeLists.txt M +5 -0 src/plasma/private/theme_p.cpp M +12 -1 src/plasma/svg.cpp http://commits.kde.org/plasma-framework/bdda85a40deef288b7e8c82212f9c9b50a4ee0aa Thank you for the fix! Something I forgot to mention however, since I found out after creating this report: There seem to be multiple ways of colorizing SVG elements now, and hint-apply-color-scheme is just one method. I didn't test the others... but just to be safe, maybe someone can take a quick look in the code to make sure the others are still honored as well (for both Aurorae and Plasma). A full list of all color elements and their definitions exists here: https://techbase.kde.org/Development/Tutorials/Plasma4/ThemeDetails#Using_system_colors I can confirm that the specific color elements are working for Aurorae themes, I tested ColorScheme-Background and ColorScheme-ViewHover. I will later check if they work for Plasmashell as well, although there are likely no more problems. Git commit 534733558c76572a191b21ebe065d335843e2855 by Marco Martin. Committed on 28/01/2015 at 13:45. Pushed by mart into branch 'master'. restore hint-apply-color-scheme support make hint-apply-color-scheme work (kiconeffect based coloring), and make sure the kcolorschemes are reloaded when app palette changes and the theme follows system colors Change-Id: I0a7a7eb0f89ed0948e618f1d608521f235aa1959 M +11 -0 src/plasma/svg.cpp http://commits.kde.org/plasma-framework/534733558c76572a191b21ebe065d335843e2855 |