Summary: | plasmashell crash overwrites current clipboard with old data | ||
---|---|---|---|
Product: | [Applications] klipper | Reporter: | Eike Hein <hein> |
Component: | general | Assignee: | Martin Flöser <mgraesslin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | BryanFRitt, piomar123 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/plasma-workspace/9e69e845044bb07c7aef4831e05c45cba68ac1d1 | Version Fixed In: | 5.3.0 |
Description
Eike Hein
2015-01-26 14:44:31 UTC
approach 2: https://git.reviewboard.kde.org/r/122382/ Git commit 9e69e845044bb07c7aef4831e05c45cba68ac1d1 by Martin Gräßlin. Committed on 02/02/2015 at 15:05. Pushed by graesslin into branch 'master'. [klipper] Sync history to disk after each change By invoking saveHistory after each change we ensure that the clipboard doesn't lose data in case klipper (or in dataengine mode plasmashell) crashes. To not cause stalls, the saving is performed in a thread using QtConcurrentRun. As klipper itself is not thread save a Mutex is used to lock changes in the HistoryModel. To not overload the system the save operations are delayed and queued. Each save is delayed by five seconds since the last clipboard change. So if the clipboard is changed multiple times in a short interval it doesn't get synced to the disk till the interaction has settled. FIXED-IN: 5.3.0 REVIEW: 122382 M +1 -0 klipper/CMakeLists.txt M +7 -0 klipper/historymodel.cpp M +6 -0 klipper/historymodel.h M +18 -0 klipper/klipper.cpp M +1 -0 klipper/klipper.h http://commits.kde.org/plasma-workspace/9e69e845044bb07c7aef4831e05c45cba68ac1d1 *** Bug 354125 has been marked as a duplicate of this bug. *** *** Bug 376408 has been marked as a duplicate of this bug. *** |