Bug 343328

Summary: Copy ends up in the undo stack
Product: [Applications] krita Reporter: Halla Rempt <halla>
Component: ToolsAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 2.9 Beta   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/c55fc01853631061df04b05ff65fd0f315c2a0bf Version Fixed In:

Description Halla Rempt 2015-01-26 13:39:59 UTC 
A Copy action doesn't change the image so it should not be put on the undo stack. Right now it is, because of the code shared with the Cut action.
Comment 1 Halla Rempt 2015-01-26 19:55:11 UTC 
Git commit c55fc01853631061df04b05ff65fd0f315c2a0bf by Boudewijn Rempt.
Committed on 26/01/2015 at 14:01.
Pushed by rempt into branch 'calligra/2.9'.

Don't push Copy onto the undo stack

The copy action doesn't affect the document state, so doesn't need
to be undoable (and in fact, undoing a copy didn't undo the change
to the clipboard).

M  +40   -38   krita/ui/actions/kis_selection_action_factories.cpp

http://commits.kde.org/calligra/c55fc01853631061df04b05ff65fd0f315c2a0bf