Bug 343287

Summary: Crop Tool has some weird behaviors on Keep Ratio (2015-01-26)
Product: [Applications] krita Reporter: Tyson Tan <tysontanx>
Component: Tools/TransformAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/calligra/0718845c11e48cfa2ea5ce5e3a19dc5f0cc31a2f Version Fixed In:
Sentry Crash Report:
Attachments: disable saving the force ratio option

Description Tyson Tan 2015-01-25 17:15:19 UTC 
After Bug 342842 & Bug 342844 being fixed, [Crop Tool] has some weird behaviors on its [Keep Ratio] feature.

Reproducible: Always

Steps to Reproduce:
A: Before I deleted the file: kritarc

A1. Every FIRST time when I use [Crop Tool] after RESTARTING Krita...
A2. As soon as I click [Crop Tool], the [Ratio] jumps to 0.70, the crop handles automatically selects an area larger than the canvas. I supposed I used that setting once.
A3. Wouldn't happen again UNLESS I restart Krita.
A4. No matter how I change [Crop Tool]'s settings, things from [Step A2] would always happen. 

From [Step A4] I suspect it to be related to the settings, so I deleted kritarc under $HOME/.kde folder. But there is still something wrong...

===========================

B: After I deleted the file kritarc

B1. Every FIRST time when I use [Crop Tool] after RESTARTING Krita...
-----------------------
B2-1-1. If the last time I closed Krita with [Keep Ratio] checked...
B2-1-2. As soon as I click [Crop Tool], [Keep Ratio] is automatically checked with its value set to 1.00. So I will be dragging a square. 
B2-1-3. No matter how I change the settings of [Crop Tool], the situation/number from [B2-1-2] will always be the same.
-----------------------
B2-2-1. If the last time I closed Krita with [Keep Ratio] UNCHECKED...
B2-2-2. Everything works as it should.




Suggestion: We probably don't want to remember [Keep Ratio] state, once we closed Krita.
Comment 1 Halla Rempt 2015-01-30 10:58:40 UTC 
Created attachment 90811 [details]
disable saving the force ratio option

Could you apply the attached patch and test? I'm not sure I've thought through all the consequences... 

Just do git apply ratio.diff in the source directory and rebuild.
Comment 2 Tyson Tan 2015-01-30 16:31:18 UTC 
Hi Boud! After applying the patch, the crop tool ratio is now working as I expected. No problem found so far. I will report back should I found anything wrong in the future. Thank you for the patch!
Comment 3 Halla Rempt 2015-01-30 16:42:16 UTC 
Git commit 0718845c11e48cfa2ea5ce5e3a19dc5f0cc31a2f by Boudewijn Rempt.
Committed on 30/01/2015 at 16:41.
Pushed by rempt into branch 'calligra/2.9'.

M  +2    -2    krita/plugins/tools/tool_crop/kis_tool_crop.cc

http://commits.kde.org/calligra/0718845c11e48cfa2ea5ce5e3a19dc5f0cc31a2f