Bug 343282

Summary:	Menu >> Image >> Size Canvas >> Should UNCHECK [Constrain Proportion] by default
Product:	[Applications] krita	Reporter:	Tyson Tan <tysontanx>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	http://commits.kde.org/calligra/5710dd5ac26b8df9d3e8d7be2546ba72f75d8750	Version Fixed In:
Sentry Crash Report:

Description Tyson Tan 2015-01-25 15:55:07 UTC

At the moment, Menu >> Size Canvas has [Constrain Proportion] checked by default. 

The problem is, I don't think we need [Constrain Proportion] that often. In fact, I never needed this function in Canvas Size dialogue for once. In most cases when I want Constant Proportion, I would use [Scale to New Size] instead. Having it checked by default resulting in me unchecking it EVERY TIME, which can be very annoying sometimes.

As far as I can remember, GIMP and Adobe Photoshop both have [Constrain Proportion] UNCHECKED by default.

==================

BTW, the menu item named [Size Canvas] has a dialogue window title as [Canvas Size]. I think renaming the menu item to [Canvas Size] is better, because 1) "Canvas Size" is widely used; 2) "Size" is not a common verb.

Reproducible: Always

Comment 1 Halla Rempt 2015-01-27 09:26:37 UTC

Git commit 5710dd5ac26b8df9d3e8d7be2546ba72f75d8750 by Boudewijn Rempt.
Committed on 27/01/2015 at 09:24.
Pushed by rempt into branch 'calligra/2.9'.

Also fix the menu labels and dialog captions.

What I don't get is why we have both the checkbox and the anchor button,
which seem to be absolutely synchronized.

M  +15   -7    krita/plugins/extensions/imagesize/dlg_canvassize.cc
M  +5    -5    krita/plugins/extensions/imagesize/dlg_imagesize.cc
M  +5    -5    krita/plugins/extensions/imagesize/dlg_layersize.cc
M  +4    -4    krita/plugins/extensions/imagesize/imagesize.cc
M  +2    -2    krita/plugins/extensions/imagesize/wdg_canvassize.ui
M  +2    -2    krita/plugins/extensions/imagesize/wdg_imagesize.ui
M  +1    -1    krita/plugins/extensions/imagesize/wdg_layersize.ui

http://commits.kde.org/calligra/5710dd5ac26b8df9d3e8d7be2546ba72f75d8750

Comment 2 Tyson Tan 2015-01-27 11:47:29 UTC

Hi Boud, thanks for the last patch, but for some reason it didn't work:
1. Now after the patch, [Resize Canvas] dialogue does seem to remember the checkbox state of [Constrain Proportion], but...
2. Once I change number for [Width] or [Height], the other will change accordingly, as if the checkbox is always checked...
3. I can "clear the state" by doing Check/Uncheck [Constrain proportion] once. Only after that the proportion is truly unlocked...
4. Next time I open [Resize Canvas] dialogue, same thing will happen again.

I had deleted kritarc before the testing to confirm that.

Comment 3 Halla Rempt 2015-01-27 12:03:14 UTC

Git commit 581f0f223e815c9c1e978d567e7747db9ce25a48 by Boudewijn Rempt.
Committed on 27/01/2015 at 11:59.
Pushed by rempt into branch 'calligra/2.9'.

M  +2    -0    krita/plugins/extensions/imagesize/dlg_canvassize.cc

http://commits.kde.org/calligra/581f0f223e815c9c1e978d567e7747db9ce25a48

Comment 4 Tyson Tan 2015-01-27 12:18:49 UTC

This time it worked like a charm! Thanks! :)