Bug 343124

Summary: Use "Close all other output views" is breaking filtered Output in not closed view
Product: [Developer tools] kdevplatform Reporter: Piotr Mierzwinski <piotr.mierzwinski>
Component: outputviewAssignee: kdevelop-bugs-null
Status: RESOLVED FIXED    
Severity: normal CC: cordlandwehr, nhaehnle, piotr.mierzwinski
Priority: NOR Keywords: junior-jobs
Version First Reported In: 5.0.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/kdevelop/4fb465589abaec300c75c01d0a8274d3fff0b316 Version Fixed/Implemented In: 5.2.4
Sentry Crash Report:

Description Piotr Mierzwinski 2015-01-21 16:34:43 UTC 
Opened couple of "Output" views. One of them is filtered (might be last one) with some string which one brings some result(s). And now calling "Close all other output views" close views (fine), cleaning edit box (probably wrong) with filtering string and as result make not possible to restore Output view from before filtering. Outcome in filtered output is correct, but original application can't restore.


Reproducible: Always

Steps to Reproduce:
1. Start application (which one produce some output) at least twice (in the same run mode) and close it each time.
2. Go to Output view.
3, Set some filtering string what bring result(s).
4. Click "Close all other output views"


Actual Results:  
1. All other views are closed.
2. Cleaned edit box (where I've put filtering string).
3. View contains result of filtering.
4. It's not able to restore/get data from before filtering (original outcome from application).

Expected Results:  
1. All other views are closed.
2. Not cleaned edit box (where I've put filtering string).
3. View contains result of filtering.
4. Ability of restoring/getting data from before filtering (original outcome from application).
Comment 1 Nicolai Hähnle 2015-01-21 19:40:07 UTC 
Dear Piotr, thank you for a high-quality bug report.

Confirmed also on the KF5-based master. Even nastier, at least on master it also crashes if you later edit the filter.

Anybody who reads this: Feel free to look into this, it's probably not too difficult :)
Comment 2 Nicolai Hähnle 2015-01-26 16:56:41 UTC 
*** Bug 343168 has been marked as a duplicate of this bug. ***
Comment 3 Milian Wolff 2015-01-27 12:43:14 UTC 
Git commit 23fa7951ee49d1b83413f0a7e0bf65aff8feabbc by Milian Wolff.
Committed on 27/01/2015 at 12:42.
Pushed by mwolff into branch '1.7'.

Cleanup code to prevent crashes when accessing nullptr.

M  +9    -8    plugins/standardoutputview/outputwidget.cpp

http://commits.kde.org/kdevplatform/23fa7951ee49d1b83413f0a7e0bf65aff8feabbc
Comment 4 Kevin Funk 2016-09-08 10:25:10 UTC 
*** Bug 339900 has been marked as a duplicate of this bug. ***
Comment 5 Piotr Mierzwinski 2016-09-08 21:39:27 UTC 
In KDevelop 5 this bug still persist.
Below I remind the steps to reproduce this bug.

1. Run ("Execute Launch") your application in KDevelop what produce some output. Close it
2. Run again your application
    Now there is two Run outputs.
3. Put something in filter what matches to some string in Run output
    You should receive some result, for example couple matching lines instead of 100 (original output)
4. Click button on Run output with description "Close all other output views"
In result: 
 - filter filed is cleaned 
-  we are no able to restore original content of "Run" output
Comment 6 Piotr Mierzwinski 2016-09-08 21:44:20 UTC 
My system. 
Linux 4.7.2-1-ARCH
KF-5.25, Qt-5.7.0
Packages built from git (at 2016/09/05), brach 5.0.
kdevelop-git-debug-5.0.0.r23429.f5cf3c6
kdevplatform-git-debug-5.0.0.r13375.d5aa9f3
Comment 7 Kevin Funk 2018-08-16 09:32:05 UTC 
Git commit 4fb465589abaec300c75c01d0a8274d3fff0b316 by Kevin Funk, on behalf of Vyacheslav Korneev.
Committed on 16/08/2018 at 09:31.
Pushed by kfunk into branch '5.2'.

Fix problems with output filters in StandardOutputView plugin

Summary:
Multiple problems with filters in StandardOutputView plugin including
discrepancy between output view, filter and proxy model were caused by
using the tab index instead of view index as a key to m_filters and
m_proxyModels maps.

Reviewers: #kdevelop, brauch

Subscribers: kfunk, brauch, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D14750

M  +20   -16   plugins/standardoutputview/outputwidget.cpp

https://commits.kde.org/kdevelop/4fb465589abaec300c75c01d0a8274d3fff0b316